Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Side by Side Diff: chrome/browser/component_updater/sw_reporter_installer_win.h

Issue 2483513002: Revert of Makes the component installers return a Result instead of a bool. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_SW_REPORTER_INSTALLER_WIN_H_ 5 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_SW_REPORTER_INSTALLER_WIN_H_
6 #define CHROME_BROWSER_COMPONENT_UPDATER_SW_REPORTER_INSTALLER_WIN_H_ 6 #define CHROME_BROWSER_COMPONENT_UPDATER_SW_REPORTER_INSTALLER_WIN_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 public: 49 public:
50 SwReporterInstallerTraits(const SwReporterRunner& reporter_runner, 50 SwReporterInstallerTraits(const SwReporterRunner& reporter_runner,
51 bool is_experimental_engine_supported); 51 bool is_experimental_engine_supported);
52 ~SwReporterInstallerTraits() override; 52 ~SwReporterInstallerTraits() override;
53 53
54 // ComponentInstallerTraits implementation. 54 // ComponentInstallerTraits implementation.
55 bool VerifyInstallation(const base::DictionaryValue& manifest, 55 bool VerifyInstallation(const base::DictionaryValue& manifest,
56 const base::FilePath& dir) const override; 56 const base::FilePath& dir) const override;
57 bool SupportsGroupPolicyEnabledComponentUpdates() const override; 57 bool SupportsGroupPolicyEnabledComponentUpdates() const override;
58 bool RequiresNetworkEncryption() const override; 58 bool RequiresNetworkEncryption() const override;
59 update_client::CrxInstaller::Result OnCustomInstall( 59 bool OnCustomInstall(const base::DictionaryValue& manifest,
60 const base::DictionaryValue& manifest, 60 const base::FilePath& install_dir) override;
61 const base::FilePath& install_dir) override;
62 void ComponentReady(const base::Version& version, 61 void ComponentReady(const base::Version& version,
63 const base::FilePath& install_dir, 62 const base::FilePath& install_dir,
64 std::unique_ptr<base::DictionaryValue> manifest) override; 63 std::unique_ptr<base::DictionaryValue> manifest) override;
65 base::FilePath GetRelativeInstallDir() const override; 64 base::FilePath GetRelativeInstallDir() const override;
66 void GetHash(std::vector<uint8_t>* hash) const override; 65 void GetHash(std::vector<uint8_t>* hash) const override;
67 std::string GetName() const override; 66 std::string GetName() const override;
68 update_client::InstallerAttributes GetInstallerAttributes() const override; 67 update_client::InstallerAttributes GetInstallerAttributes() const override;
69 std::vector<std::string> GetMimeTypes() const override; 68 std::vector<std::string> GetMimeTypes() const override;
70 69
71 private: 70 private:
(...skipping 16 matching lines...) Expand all
88 // Register local state preferences related to the SwReporter. 87 // Register local state preferences related to the SwReporter.
89 void RegisterPrefsForSwReporter(PrefRegistrySimple* registry); 88 void RegisterPrefsForSwReporter(PrefRegistrySimple* registry);
90 89
91 // Register profile preferences related to the SwReporter. 90 // Register profile preferences related to the SwReporter.
92 void RegisterProfilePrefsForSwReporter( 91 void RegisterProfilePrefsForSwReporter(
93 user_prefs::PrefRegistrySyncable* registry); 92 user_prefs::PrefRegistrySyncable* registry);
94 93
95 } // namespace component_updater 94 } // namespace component_updater
96 95
97 #endif // CHROME_BROWSER_COMPONENT_UPDATER_SW_REPORTER_INSTALLER_WIN_H_ 96 #endif // CHROME_BROWSER_COMPONENT_UPDATER_SW_REPORTER_INSTALLER_WIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698