Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/component_updater/sw_reporter_installer_win.cc

Issue 2483513002: Revert of Makes the component installers return a Result instead of a bool. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/component_updater/sw_reporter_installer_win.h" 5 #include "chrome/browser/component_updater/sw_reporter_installer_win.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <map> 10 #include <map>
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 305
306 bool SwReporterInstallerTraits::SupportsGroupPolicyEnabledComponentUpdates() 306 bool SwReporterInstallerTraits::SupportsGroupPolicyEnabledComponentUpdates()
307 const { 307 const {
308 return true; 308 return true;
309 } 309 }
310 310
311 bool SwReporterInstallerTraits::RequiresNetworkEncryption() const { 311 bool SwReporterInstallerTraits::RequiresNetworkEncryption() const {
312 return false; 312 return false;
313 } 313 }
314 314
315 update_client::CrxInstaller::Result SwReporterInstallerTraits::OnCustomInstall( 315 bool SwReporterInstallerTraits::OnCustomInstall(
316 const base::DictionaryValue& manifest, 316 const base::DictionaryValue& manifest,
317 const base::FilePath& install_dir) { 317 const base::FilePath& install_dir) {
318 return update_client::CrxInstaller::Result(0); 318 return true;
319 } 319 }
320 320
321 void SwReporterInstallerTraits::ComponentReady( 321 void SwReporterInstallerTraits::ComponentReady(
322 const base::Version& version, 322 const base::Version& version,
323 const base::FilePath& install_dir, 323 const base::FilePath& install_dir,
324 std::unique_ptr<base::DictionaryValue> manifest) { 324 std::unique_ptr<base::DictionaryValue> manifest) {
325 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 325 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
326 const base::FilePath exe_path(install_dir.Append(kSwReporterExeName)); 326 const base::FilePath exe_path(install_dir.Append(kSwReporterExeName));
327 if (IsExperimentalEngineEnabled()) { 327 if (IsExperimentalEngineEnabled()) {
328 RunExperimentalSwReporter(exe_path, version, std::move(manifest), 328 RunExperimentalSwReporter(exe_path, version, std::move(manifest),
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 } 491 }
492 492
493 void RegisterProfilePrefsForSwReporter( 493 void RegisterProfilePrefsForSwReporter(
494 user_prefs::PrefRegistrySyncable* registry) { 494 user_prefs::PrefRegistrySyncable* registry) {
495 registry->RegisterStringPref(prefs::kSwReporterPromptVersion, ""); 495 registry->RegisterStringPref(prefs::kSwReporterPromptVersion, "");
496 496
497 registry->RegisterStringPref(prefs::kSwReporterPromptSeed, ""); 497 registry->RegisterStringPref(prefs::kSwReporterPromptSeed, "");
498 } 498 }
499 499
500 } // namespace component_updater 500 } // namespace component_updater
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698