Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: chrome/browser/component_updater/pnacl_component_installer.h

Issue 2483513002: Revert of Makes the component installers return a Result instead of a bool. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/pnacl_component_installer.h
diff --git a/chrome/browser/component_updater/pnacl_component_installer.h b/chrome/browser/component_updater/pnacl_component_installer.h
index 3f3981c382854f17f94d1c66aac1ec1655df1442..5e44209c4ea2727540b62a970fa010404fdcb6a1 100644
--- a/chrome/browser/component_updater/pnacl_component_installer.h
+++ b/chrome/browser/component_updater/pnacl_component_installer.h
@@ -43,9 +43,8 @@
// ComponentInstaller implementation:
void OnUpdateError(int error) override;
- update_client::CrxInstaller::Result Install(
- const base::DictionaryValue& manifest,
- const base::FilePath& unpack_path) override;
+ bool Install(const base::DictionaryValue& manifest,
+ const base::FilePath& unpack_path) override;
bool GetInstalledFile(const std::string& file,
base::FilePath* installed_file) override;
bool Uninstall() override;
@@ -75,9 +74,6 @@
private:
~PnaclComponentInstaller() override;
- bool DoInstall(const base::DictionaryValue& manifest,
- const base::FilePath& unpack_path);
-
base::Version current_version_;
std::string current_fingerprint_;
ComponentUpdateService* cus_;

Powered by Google App Engine
This is Rietveld 408576698