Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: components/update_client/update_client_errors.h

Issue 2483513002: Revert of Makes the component installers return a Result instead of a bool. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/update_client.h ('k') | components/update_client/update_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/update_client_errors.h
diff --git a/components/update_client/update_client_errors.h b/components/update_client/update_client_errors.h
index 08b13a299f2071223e34229f6653e7642f8e1ba4..34a65da4cdaacf6c58dcf051d8482207994fae35 100644
--- a/components/update_client/update_client_errors.h
+++ b/components/update_client/update_client_errors.h
@@ -41,39 +41,29 @@
};
// These errors are returned with the |kUnpackError| error category and
-// indicate unpacker or patcher error.
+// indicate unpacker, patcher, or install errors.
enum class UnpackerError {
kNone = 0,
- kInvalidParams = 1,
- kInvalidFile = 2,
- kUnzipPathError = 3,
- kUnzipFailed = 4,
- // kNoManifest = 5, // Deprecated. Never used.
- kBadManifest = 6,
- kBadExtension = 7,
- kInvalidId = 8,
- // kInstallerError = 9, // Deprecated. Don't use.
- kIoError = 10,
- kDeltaVerificationFailure = 11,
- kDeltaBadCommands = 12,
- kDeltaUnsupportedCommand = 13,
- kDeltaOperationFailure = 14,
- kDeltaPatchProcessFailure = 15,
- kDeltaMissingExistingFile = 16,
- // kFingerprintWriteFailed = 17, // Deprecated. Don't use.
+ kInvalidParams,
+ kInvalidFile,
+ kUnzipPathError,
+ kUnzipFailed,
+ kNoManifest,
+ kBadManifest,
+ kBadExtension,
+ kInvalidId,
+ kInstallerError,
+ kIoError,
+ kDeltaVerificationFailure,
+ kDeltaBadCommands,
+ kDeltaUnsupportedCommand,
+ kDeltaOperationFailure,
+ kDeltaPatchProcessFailure,
+ kDeltaMissingExistingFile,
+ kFingerprintWriteFailed,
};
// These errors are returned with the |kServiceError| error category and
-// are returned by the component installers.
-enum class InstallError {
- NONE = 0,
- FINGERPRINT_WRITE_FAILED = 2,
- BAD_MANIFEST = 3,
- GENERIC_ERROR = 9, // Matches kInstallerError for compatibility.
- CUSTOM_ERROR_BASE = 100, // Specific installer errors go above this value.
-};
-
-// These errors are returned with the |kInstallError| error category and
// indicate critical or configuration errors in the update service.
enum class ServiceError {
NONE = 0,
« no previous file with comments | « components/update_client/update_client.h ('k') | components/update_client/update_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698