Move enable extensions define to a build flag.

Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.

The json_schema_compiler tests were moved from the unit tests target to one on their directory with an extensions-only dependency on the new test target.

Committed: https://crrev.com/00899e685f753f1e8b0b2452bf374de5f0079feb
Cr-Commit-Position: refs/heads/master@{#431741}

[brettw, 2016-11-03 23:14:52]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 23:16:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 23:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:23:35]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-11-04 22:50:40]

Merge

[brettw, 2016-11-04 22:50:41]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-11-04 22:51:03]

Description was changed from

==========
Move enable extensions build flag
==========

to

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.
==========

[commit-bot: I haz the power, 2016-11-04 22:51:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-11-04 22:51:46]

brettw@chromium.org changed reviewers:
+ asargent@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:59:05]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[asargent_no_longer_on_chrome, 2016-11-07 21:32:24]

lgtm

[brettw, 2016-11-07 22:48:57]

Merge

[brettw, 2016-11-07 22:48:58]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 22:49:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 22:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 22:57:17]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2016-11-07 23:28:27]

Fix check

[brettw, 2016-11-07 23:28:28]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 23:29:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-11-07 23:32:28]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-11-07 23:32:37]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-07 23:32:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593006/#ps60001
(title: "Fix check")

[commit-bot: I haz the power, 2016-11-07 23:33:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 23:45:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:45:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-11-07 23:59:08]

Fix

[brettw, 2016-11-07 23:59:09]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-07 23:59:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593006/#ps80001
(title: "Fix")

[commit-bot: I haz the power, 2016-11-07 23:59:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 00:17:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 00:17:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-11-08 00:22:20]

Description was changed from

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.
==========

to

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.

R=asargent
TBR=dbeam (webui)
TBR=tsepez (messages and IPC whitelist)
==========

[brettw, 2016-11-08 00:22:20]

brettw@chromium.org changed reviewers:
+ dbeam@chromium.org, tsepez@chromium.org

[brettw, 2016-11-08 00:25:06]

TBR extra owners for mechanical changes.

[brettw, 2016-11-08 00:28:33]

extensions/test

[brettw, 2016-11-08 00:28:33]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-08 00:28:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593006/#ps100001
(title: "extensions/test")

[commit-bot: I haz the power, 2016-11-08 00:29:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 01:07:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-11-08 07:43:03]

rs lgtm

[Tom Sepez, 2016-11-08 18:26:43]

RS LGTM

[brettw, 2016-11-08 18:31:28]

Fix

[brettw, 2016-11-08 18:31:30]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-08 18:31:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
asargent@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593006/#ps120001
(title: "Fix")

[commit-bot: I haz the power, 2016-11-08 18:32:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 20:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 20:34:10]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-08 21:06:27]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-08 21:07:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 23:09:00]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-09 02:34:41]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-09 02:35:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 03:13:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 03:13:09]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-09 19:01:58]

Merge (previous patch OK)

[brettw, 2016-11-09 19:01:59]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-09 19:02:00]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
asargent@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593006/#ps140001
(title: "Merge (previous patch OK)")

[commit-bot: I haz the power, 2016-11-09 19:02:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 19:34:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 19:34:55]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-09 21:51:21]

I tired of playing whack-a-mole with missing json_features deps. Since the
script automatically writes includes in extensions/common, I made the GN
template automatically add a dependency on that target.

[brettw, 2016-11-09 21:59:56]

json_features

[brettw, 2016-11-09 21:59:57]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-09 21:59:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
asargent@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593006/#ps160001
(title: "json_features")

[commit-bot: I haz the power, 2016-11-09 22:00:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[asargent_no_longer_on_chrome, 2016-11-09 22:04:41]

On 2016/11/09 21:51:21, brettw (ping on IM after 24h) wrote:
> I tired of playing whack-a-mole with missing json_features deps. Since the
> script automatically writes includes in extensions/common, I made the GN
> template automatically add a dependency on that target.

Out of curiousity, what file did you make that change in?

[commit-bot: I haz the power, 2016-11-09 22:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 22:09:14]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[brettw, 2016-11-09 22:18:51]

json_features.gni has the default extensions dep (and I removed it where it was
added manually in previous patches)

[asargent_no_longer_on_chrome, 2016-11-09 22:49:45]

On 2016/11/09 22:18:51, brettw (ping on IM after 24h) wrote:
> json_features.gni has the default extensions dep (and I removed it where it
was
> added manually in previous patches)

Ah, I see it now, thanks.

[brettw, 2016-11-10 22:44:13]

Test updates

[brettw, 2016-11-10 22:44:15]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-10 22:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
asargent@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593006/#ps180001
(title: "Test updates")

[commit-bot: I haz the power, 2016-11-10 22:44:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-11-10 22:45:38]

Description was changed from

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.

R=asargent
TBR=dbeam (webui)
TBR=tsepez (messages and IPC whitelist)
==========

to

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.

The json_schema_compiler tests were moved from the unit tests target to one on
their directory with an extensions-only dependency on the new test target.
==========

[brettw, 2016-11-10 22:47:29]

New change to tools/json_schema_compiler/test/BUILD.gn and chrome/test/BUILD.gn.
The test build rules were moved to their own build file and these tests were
made conditional on the extensions being enabled. Previously they were compiled
on Android when they're not run, and the includes used extensions headers which
makes everything break when you're pedantic about dependencies.

[commit-bot: I haz the power, 2016-11-11 00:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 00:48:55]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-11-11 02:02:51]

https://codereview.chromium.org/2479593006/diff/180001/tools/grit/grit_rule.gni
File tools/grit/grit_rule.gni (left):

https://codereview.chromium.org/2479593006/diff/180001/tools/grit/grit_rule.g...
tools/grit/grit_rule.gni:247: "enable_extensions",
is this needed for something like <if expr="enable_extensions"> in a .grd file? 
if so, these may be affected:
https://cs.chromium.org/search/?q=%3Cif%5Csexpr%3D.*enable_extensions&sq=pack...

[brettw, 2016-11-11 17:44:18]

https://codereview.chromium.org/2479593006/diff/180001/tools/grit/grit_rule.gni
File tools/grit/grit_rule.gni (left):

https://codereview.chromium.org/2479593006/diff/180001/tools/grit/grit_rule.g...
tools/grit/grit_rule.gni:247: "enable_extensions",
The addition to chrome/common/features.gni will handle all of these cases.
Thanks for checking.

[brettw, 2016-11-11 17:45:00]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-11 17:45:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 21:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 21:10:30]

Failed to apply patch for chrome/utility/DEPS:
While running git apply --index -p1;
  error: patch failed: chrome/utility/DEPS:7
  error: chrome/utility/DEPS: patch does not apply

Patch:       chrome/utility/DEPS
Index: chrome/utility/DEPS
diff --git a/chrome/utility/DEPS b/chrome/utility/DEPS
index
a43b1da55edee93b6fbddf99da27384aa3a586fd..932d31f99a749d5395ca0acdbc6fed0251c6d53b
100644
--- a/chrome/utility/DEPS
+++ b/chrome/utility/DEPS
@@ -7,6 +7,7 @@ include_rules = [
   "+content/public/utility",
   "+courgette",
   "+extensions/common",
+  "+extensions/features",
   "+media",
   "+services/service_manager/public/cpp",
   "+skia/ext",

[brettw, 2016-11-11 21:16:56]

Merge

[brettw, 2016-11-11 21:16:57]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-11 21:16:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
asargent@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2479593006/#ps200001
(title: "Merge")

[commit-bot: I haz the power, 2016-11-11 21:17:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 23:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 23:19:13]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-12 00:12:01]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-12 00:13:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 02:10:45]

Description was changed from

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.

The json_schema_compiler tests were moved from the unit tests target to one on
their directory with an extensions-only dependency on the new test target.
==========

to

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.

The json_schema_compiler tests were moved from the unit tests target to one on
their directory with an extensions-only dependency on the new test target.
==========

[commit-bot: I haz the power, 2016-11-12 02:10:49]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-11-12 02:13:51]

Description was changed from

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.

The json_schema_compiler tests were moved from the unit tests target to one on
their directory with an extensions-only dependency on the new test target.
==========

to

==========
Move enable extensions define to a build flag.

Removes the global define and convert to a more scaleable build flag system.

The json_schema_compiler tests were moved from the unit tests target to one on
their directory with an extensions-only dependency on the new test target.

Committed: https://crrev.com/00899e685f753f1e8b0b2452bf374de5f0079feb
Cr-Commit-Position: refs/heads/master@{#431741}
==========

[commit-bot: I haz the power, 2016-11-12 02:13:54]

Patchset 11 (id:??) landed as
https://crrev.com/00899e685f753f1e8b0b2452bf374de5f0079feb
Cr-Commit-Position: refs/heads/master@{#431741}