Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/browser/interstitials/chrome_metrics_helper.h

Issue 2479593006: Move enable extensions define to a build flag. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_INTERSTITIALS_CHROME_METRICS_HELPER_H_ 5 #ifndef CHROME_BROWSER_INTERSTITIALS_CHROME_METRICS_HELPER_H_
6 #define CHROME_BROWSER_INTERSTITIALS_CHROME_METRICS_HELPER_H_ 6 #define CHROME_BROWSER_INTERSTITIALS_CHROME_METRICS_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "chrome/common/features.h" 11 #include "chrome/common/features.h"
12 #include "components/security_interstitials/core/metrics_helper.h" 12 #include "components/security_interstitials/core/metrics_helper.h"
13 #include "extensions/features/features.h"
13 #include "url/gurl.h" 14 #include "url/gurl.h"
14 15
15 namespace content { 16 namespace content {
16 class WebContents; 17 class WebContents;
17 } 18 }
18 19
19 namespace extensions { 20 namespace extensions {
20 class ExperienceSamplingEvent; 21 class ExperienceSamplingEvent;
21 } 22 }
22 23
(...skipping 17 matching lines...) Expand all
40 41
41 protected: 42 protected:
42 // security_interstitials::MetricsHelper methods: 43 // security_interstitials::MetricsHelper methods:
43 void RecordExtraUserDecisionMetrics( 44 void RecordExtraUserDecisionMetrics(
44 security_interstitials::MetricsHelper::Decision decision) override; 45 security_interstitials::MetricsHelper::Decision decision) override;
45 void RecordExtraUserInteractionMetrics( 46 void RecordExtraUserInteractionMetrics(
46 security_interstitials::MetricsHelper::Interaction interaction) override; 47 security_interstitials::MetricsHelper::Interaction interaction) override;
47 void RecordExtraShutdownMetrics() override; 48 void RecordExtraShutdownMetrics() override;
48 49
49 private: 50 private:
50 #if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION) || defined(ENABLE_EXTENSIONS) 51 #if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION) || BUILDFLAG(ENABLE_EXTENSIONS)
51 content::WebContents* web_contents_; 52 content::WebContents* web_contents_;
52 #endif 53 #endif
53 const GURL request_url_; 54 const GURL request_url_;
54 const std::string sampling_event_name_; 55 const std::string sampling_event_name_;
55 #if defined(ENABLE_EXTENSIONS) 56 #if BUILDFLAG(ENABLE_EXTENSIONS)
56 std::unique_ptr<extensions::ExperienceSamplingEvent> sampling_event_; 57 std::unique_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
57 #endif 58 #endif
58 #if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION) 59 #if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION)
59 std::unique_ptr<CaptivePortalMetricsRecorder> captive_portal_recorder_; 60 std::unique_ptr<CaptivePortalMetricsRecorder> captive_portal_recorder_;
60 #endif 61 #endif
61 62
62 DISALLOW_COPY_AND_ASSIGN(ChromeMetricsHelper); 63 DISALLOW_COPY_AND_ASSIGN(ChromeMetricsHelper);
63 }; 64 };
64 65
65 #endif // CHROME_BROWSER_INTERSTITIALS_CHROME_METRICS_HELPER_H_ 66 #endif // CHROME_BROWSER_INTERSTITIALS_CHROME_METRICS_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698