Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/chrome_notification_types.h

Issue 2479593006: Move enable extensions define to a build flag. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/chromeos/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_ 5 #ifndef CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
6 #define CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_ 6 #define CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "extensions/features/features.h"
9 10
10 #if defined(ENABLE_EXTENSIONS) 11 #if BUILDFLAG(ENABLE_EXTENSIONS)
11 #include "extensions/browser/notification_types.h" 12 #include "extensions/browser/notification_types.h"
12 #else 13 #else
13 #include "content/public/browser/notification_types.h" 14 #include "content/public/browser/notification_types.h"
14 #endif 15 #endif
15 16
16 #if defined(ENABLE_EXTENSIONS) 17 #if BUILDFLAG(ENABLE_EXTENSIONS)
17 #define PREVIOUS_END extensions::NOTIFICATION_EXTENSIONS_END 18 #define PREVIOUS_END extensions::NOTIFICATION_EXTENSIONS_END
18 #else 19 #else
19 #define PREVIOUS_END content::NOTIFICATION_CONTENT_END 20 #define PREVIOUS_END content::NOTIFICATION_CONTENT_END
20 #endif 21 #endif
21 22
22 namespace chrome { 23 namespace chrome {
23 24
24 // NotificationService &c. are deprecated (https://crbug.com/268984). 25 // NotificationService &c. are deprecated (https://crbug.com/268984).
25 // Don't add any new notification types, and migrate existing uses of the 26 // Don't add any new notification types, and migrate existing uses of the
26 // notification types below to observers. 27 // notification types below to observers.
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 // the InfoBarService the InfoBar was added to. The details is a 121 // the InfoBarService the InfoBar was added to. The details is a
121 // Details<InfoBar::AddedDetails>. 122 // Details<InfoBar::AddedDetails>.
122 NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED, 123 NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED,
123 124
124 // This message is sent when an InfoBar is about to be removed from an 125 // This message is sent when an InfoBar is about to be removed from an
125 // InfoBarService. The source is a Source<InfoBarService> with a pointer to 126 // InfoBarService. The source is a Source<InfoBarService> with a pointer to
126 // the InfoBarService the InfoBar was removed from. The details is a 127 // the InfoBarService the InfoBar was removed from. The details is a
127 // Details<InfoBar::RemovedDetails>. 128 // Details<InfoBar::RemovedDetails>.
128 NOTIFICATION_TAB_CONTENTS_INFOBAR_REMOVED, 129 NOTIFICATION_TAB_CONTENTS_INFOBAR_REMOVED,
129 130
130 #if defined(ENABLE_EXTENSIONS) 131 #if BUILDFLAG(ENABLE_EXTENSIONS)
131 // This notification is sent when extensions::TabHelper::SetExtensionApp is 132 // This notification is sent when extensions::TabHelper::SetExtensionApp is
132 // invoked. The source is the extensions::TabHelper SetExtensionApp was 133 // invoked. The source is the extensions::TabHelper SetExtensionApp was
133 // invoked on. 134 // invoked on.
134 NOTIFICATION_TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED, 135 NOTIFICATION_TAB_CONTENTS_APPLICATION_EXTENSION_CHANGED,
135 #endif 136 #endif
136 137
137 // Tabs -------------------------------------------------------------------- 138 // Tabs --------------------------------------------------------------------
138 139
139 // Sent when a tab is added to a WebContentsDelegate. The source is the 140 // Sent when a tab is added to a WebContentsDelegate. The source is the
140 // WebContentsDelegate and the details is the added WebContents. 141 // WebContentsDelegate and the details is the added WebContents.
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 307
307 // Sync -------------------------------------------------------------------- 308 // Sync --------------------------------------------------------------------
308 309
309 // The session service has been saved. This notification type is only sent 310 // The session service has been saved. This notification type is only sent
310 // if there were new SessionService commands to save, and not for no-op save 311 // if there were new SessionService commands to save, and not for no-op save
311 // operations. 312 // operations.
312 NOTIFICATION_SESSION_SERVICE_SAVED, 313 NOTIFICATION_SESSION_SERVICE_SAVED,
313 314
314 // Cookies ----------------------------------------------------------------- 315 // Cookies -----------------------------------------------------------------
315 316
316 #if defined(ENABLE_EXTENSIONS) 317 #if BUILDFLAG(ENABLE_EXTENSIONS)
317 // Sent when a cookie changes, for consumption by extensions. The source is a 318 // Sent when a cookie changes, for consumption by extensions. The source is a
318 // Profile object, the details are a ChromeCookieDetails object. 319 // Profile object, the details are a ChromeCookieDetails object.
319 NOTIFICATION_COOKIE_CHANGED_FOR_EXTENSIONS, 320 NOTIFICATION_COOKIE_CHANGED_FOR_EXTENSIONS,
320 #endif 321 #endif
321 322
322 // Download Notifications -------------------------------------------------- 323 // Download Notifications --------------------------------------------------
323 324
324 // Sent when a download is initiated. It is possible that the download will 325 // Sent when a download is initiated. It is possible that the download will
325 // not actually begin due to the DownloadRequestLimiter cancelling it 326 // not actually begin due to the DownloadRequestLimiter cancelling it
326 // prematurely. 327 // prematurely.
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 // Note:- 485 // Note:-
485 // Currently only Content and Chrome define and use notifications. 486 // Currently only Content and Chrome define and use notifications.
486 // Custom notifications not belonging to Content and Chrome should start 487 // Custom notifications not belonging to Content and Chrome should start
487 // from here. 488 // from here.
488 NOTIFICATION_CHROME_END, 489 NOTIFICATION_CHROME_END,
489 }; 490 };
490 491
491 } // namespace chrome 492 } // namespace chrome
492 493
493 #endif // CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_ 494 #endif // CHROME_BROWSER_CHROME_NOTIFICATION_TYPES_H_
OLDNEW
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/chromeos/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698