chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc - Issue 2479593006: Move enable extensions define to a build flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc

Issue 2479593006: Move enable extensions define to a build flag. (Closed)

Patch Set: Merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_stability_metrics_provider.cc ('k') | chrome/browser/nacl_host/nacl_browser_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc

diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc b/chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc

index a23da907f093fd6e16f71d49c88660e255a98736..81032d9e68a5abe1f944e0fe8e79fad218a03b72 100644

--- a/chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc

+++ b/chrome/browser/metrics/chrome_stability_metrics_provider_unittest.cc

@@ -22,9 +22,10 @@

#include "content/public/common/process_type.h"

#include "content/public/test/mock_render_process_host.h"

#include "content/public/test/test_browser_thread_bundle.h"

+#include "extensions/features/features.h"

#include "testing/gtest/include/gtest/gtest.h"

-#if defined(ENABLE_EXTENSIONS)

+#if BUILDFLAG(ENABLE_EXTENSIONS)

#include "extensions/browser/process_map.h"

#endif

@@ -131,7 +132,7 @@ TEST_F(ChromeStabilityMetricsProviderTest, NotificationObserver) {

EXPECT_EQ(1, system_profile.stability().renderer_failed_launch_count());

EXPECT_EQ(0, system_profile.stability().extension_renderer_crash_count());

-#if defined(ENABLE_EXTENSIONS)

+#if BUILDFLAG(ENABLE_EXTENSIONS)

provider.ClearSavedStabilityMetrics();

// Owned by rph_factory.