Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: tools/grit/grit_rule.gni

Issue 2479593006: Move enable extensions define to a build flag. (Closed)
Patch Set: Test updates Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « google_apis/BUILD.gn ('k') | tools/json_schema_compiler/json_features.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Instantiate grit. This will produce a script target to run grit, and a 5 # Instantiate grit. This will produce a script target to run grit, and a
6 # static library that compiles the .cc files. 6 # static library that compiles the .cc files.
7 # 7 #
8 # Parameters 8 # Parameters
9 # 9 #
10 # source (required) 10 # source (required)
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 ] 234 ]
235 } 235 }
236 if (is_win) { 236 if (is_win) {
237 grit_defines += [ 237 grit_defines += [
238 "-t", 238 "-t",
239 "win32", 239 "win32",
240 ] 240 ]
241 } 241 }
242 } 242 }
243 243
244 if (enable_extensions) {
245 grit_defines += [
246 "-D",
247 "enable_extensions",
Dan Beam 2016/11/11 02:02:51 is this needed for something like <if expr="enable
brettw 2016/11/11 17:44:18 The addition to chrome/common/features.gni will ha
248 ]
249 }
250 if (enable_media_router) { 244 if (enable_media_router) {
251 grit_defines += [ 245 grit_defines += [
252 "-D", 246 "-D",
253 "enable_media_router", 247 "enable_media_router",
254 ] 248 ]
255 } 249 }
256 if (enable_plugins) { 250 if (enable_plugins) {
257 grit_defines += [ 251 grit_defines += [
258 "-D", 252 "-D",
259 "enable_plugins", 253 "enable_plugins",
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 if (defined(invoker.configs)) { 515 if (defined(invoker.configs)) {
522 configs += invoker.configs 516 configs += invoker.configs
523 } 517 }
524 518
525 if (defined(invoker.visibility)) { 519 if (defined(invoker.visibility)) {
526 visibility = invoker.visibility 520 visibility = invoker.visibility
527 } 521 }
528 output_name = grit_output_name 522 output_name = grit_output_name
529 } 523 }
530 } 524 }
OLDNEW
« no previous file with comments | « google_apis/BUILD.gn ('k') | tools/json_schema_compiler/json_features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698