Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: build/config/features.gni

Issue 2479593006: Move enable extensions define to a build flag. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================= 5 # =============================================
6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
7 # ============================================= 7 # =============================================
8 # 8 #
9 # These flags are effectively global. Your feature flag should go near the 9 # These flags are effectively global. Your feature flag should go near the
10 # code it controls. Most of these items are here now because they control 10 # code it controls. Most of these items are here now because they control
11 # legacy global #defines passed to the compiler (now replaced with generated 11 # legacy global #defines passed to the compiler (now replaced with generated
12 # buildflag headers -- see //build/buildflag_header.gni). 12 # buildflag headers -- see //build/buildflag_header.gni).
13 # 13 #
14 # There is more advice on where to put build flags in the "Build flag" section 14 # There is more advice on where to put build flags in the "Build flag" section
15 # of //build/config/BUILDCONFIG.gn. 15 # of //build/config/BUILDCONFIG.gn.
16 16
17 import("//build/config/chrome_build.gni") 17 import("//build/config/chrome_build.gni")
18 import("//build/config/chromecast_build.gni") 18 import("//build/config/chromecast_build.gni")
19 if (is_android) { 19 if (is_android) {
20 import("//build/config/android/config.gni") 20 import("//build/config/android/config.gni")
21 } 21 }
22 22
23 declare_args() { 23 declare_args() {
24 enable_extensions = !is_android && !is_ios
25 enable_plugins = (!is_android && !is_ios) || is_chromecast 24 enable_plugins = (!is_android && !is_ios) || is_chromecast
26 enable_pdf = !is_android && !is_ios && !is_chromecast 25 enable_pdf = !is_android && !is_ios && !is_chromecast
27 26
28 # Enables Native Client support. 27 # Enables Native Client support.
29 # Temporarily disable nacl on arm64 linux to get rid of compilation errors. 28 # Temporarily disable nacl on arm64 linux to get rid of compilation errors.
30 # TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion. 29 # TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion.
31 enable_nacl = !is_ios && !is_android && !is_chromecast && 30 enable_nacl = !is_ios && !is_android && !is_chromecast &&
32 current_cpu != "mipsel" && !(is_linux && target_cpu == "arm64") 31 current_cpu != "mipsel" && !(is_linux && target_cpu == "arm64")
33 32
34 # Non-SFI is not yet supported on mipsel 33 # Non-SFI is not yet supported on mipsel
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 134
136 enable_configuration_policy = !is_ios 135 enable_configuration_policy = !is_ios
137 136
138 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build 137 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build
139 # 138 #
140 # ============================================= 139 # =============================================
141 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 140 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
142 # ============================================= 141 # =============================================
143 # 142 #
144 # See comment at the top. 143 # See comment at the top.
OLDNEW
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698