Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2474353002: Allow add to homescreen and app banner strings to be changed via variations. (Closed)

Created:
4 years, 1 month ago by dominickn
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, dfalcantara+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow add to homescreen and app banner strings to be changed via variations. This CL adds a variations key to change the language of add to homescreen and app banners. This is to experiment with different strings to see the impact on click-through rates and user comprehension of the feature. BUG=662286 Committed: https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30 Cr-Commit-Position: refs/heads/master@{#431140}

Patch Set 1 #

Messages

Total messages: 18 (13 generated)
dominickn
PTAL, thanks!
4 years, 1 month ago (2016-11-04 05:46:59 UTC) #5
gone
lgtm
4 years, 1 month ago (2016-11-04 21:10:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474353002/1
4 years, 1 month ago (2016-11-10 02:05:15 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 02:10:22 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 02:13:45 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30
Cr-Commit-Position: refs/heads/master@{#431140}

Powered by Google App Engine
This is Rietveld 408576698