chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java - Issue 2474353002: Allow add to homescreen and app banner strings to be changed via variations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

Issue 2474353002: Allow add to homescreen and app banner strings to be changed via variations. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

index 208b999cedd30841dac586a1a6686811e23de397..09f3545bc761b648017d6450baff0167f84dd021 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

@@ -17,6 +17,7 @@ import android.widget.ImageView;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.banners.AppBannerManager;

/**

* Displays the "Add to Homescreen" dialog.

@@ -52,7 +53,7 @@ public class AddToHomescreenDialog implements AddToHomescreenManager.Observer {

View view = activity.getLayoutInflater().inflate(

R.layout.add_to_homescreen_dialog, null);

AlertDialog.Builder builder = new AlertDialog.Builder(activity, R.style.AlertDialogTheme)

- .setTitle(R.string.menu_add_to_homescreen)

+ .setTitle(AppBannerManager.getHomescreenLanguageOption())

.setNegativeButton(R.string.cancel,

new DialogInterface.OnClickListener() {

@Override