Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 2474353002: Allow add to homescreen and app banner strings to be changed via variations. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index 3c6a3b638312e95f488989ac154d66313cdc2f27..781d36f7056563f2effe3470f17adb7195d230c5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -11,6 +11,7 @@ import org.chromium.base.ContextUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.chrome.R;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.content_public.browser.WebContents;
@@ -128,6 +129,28 @@ public class AppBannerManager {
mIsEnabledForTab = state;
}
+ /** Returns the language option to use for the add to homescreen dialog and menu item. */
+ public static int getHomescreenLanguageOption() {
+ int languageOption = nativeGetHomescreenLanguageOption();
+ if (languageOption == LanguageOption.ADD) {
+ return R.string.menu_add_to_homescreen_add;
+ } else if (languageOption == LanguageOption.INSTALL) {
+ return R.string.menu_add_to_homescreen_install;
+ }
+ return R.string.menu_add_to_homescreen;
+ }
+
+ /** Returns the language option to use for app banners. */
+ public static int getAppBannerLanguageOption() {
+ int languageOption = nativeGetHomescreenLanguageOption();
+ if (languageOption == LanguageOption.ADD) {
+ return R.string.app_banner_add;
+ } else if (languageOption == LanguageOption.INSTALL) {
+ return R.string.app_banner_install;
+ }
+ return R.string.menu_add_to_homescreen;
+ }
+
/** Overrides whether the system supports add to home screen. Used in testing. */
@VisibleForTesting
public static void setIsSupported(boolean state) {
@@ -157,6 +180,7 @@ public class AppBannerManager {
return nativeGetJavaBannerManagerForWebContents(webContents);
}
+ private static native int nativeGetHomescreenLanguageOption();
private static native AppBannerManager nativeGetJavaBannerManagerForWebContents(
WebContents webContents);
private native boolean nativeOnAppDetailsRetrieved(long nativeAppBannerManagerAndroid,

Powered by Google App Engine
This is Rietveld 408576698