Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: chrome/browser/banners/app_banner_settings_helper.cc

Issue 2474353002: Allow add to homescreen and app banner strings to be changed via variations. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_settings_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_settings_helper.cc
diff --git a/chrome/browser/banners/app_banner_settings_helper.cc b/chrome/browser/banners/app_banner_settings_helper.cc
index fb7f13af96812c53b4036aea1e9610251b2fe13c..c93f08a677337157c77947643bd5b28f5076ca4d 100644
--- a/chrome/browser/banners/app_banner_settings_helper.cc
+++ b/chrome/browser/banners/app_banner_settings_helper.cc
@@ -81,6 +81,7 @@ const char kBannerParamsEngagementTotalKey[] = "site_engagement_total";
const char kBannerParamsDaysAfterBannerDismissedKey[] = "days_after_dismiss";
const char kBannerParamsDaysAfterBannerIgnoredKey[] = "days_after_ignore";
const char kBannerSiteEngagementParamsKey[] = "use_site_engagement";
+const char kBannerParamsLanguageKey[] = "language_option";
// Engagement weight assigned to direct and indirect navigations.
// By default, a direct navigation is a page visit via ui::PAGE_TRANSITION_TYPED
@@ -674,6 +675,21 @@ void AppBannerSettingsHelper::UpdateFromFieldTrial() {
}
}
+AppBannerSettingsHelper::LanguageOption
+AppBannerSettingsHelper::GetHomescreenLanguageOption() {
+ std::string param = variations::GetVariationParamValue(
+ kBannerParamsKey, kBannerParamsLanguageKey);
+ unsigned int language_option = 0;
+
+ if (param.empty() || !base::StringToUint(param, &language_option) ||
+ language_option < LANGUAGE_OPTION_MIN ||
+ language_option > LANGUAGE_OPTION_MAX) {
+ return LANGUAGE_OPTION_DEFAULT;
+ }
+
+ return static_cast<LanguageOption>(language_option);
+}
+
bool AppBannerSettingsHelper::ShouldUseSiteEngagementScore() {
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableSiteEngagementAppBanner)) {
« no previous file with comments | « chrome/browser/banners/app_banner_settings_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698