chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java - Issue 2474353002: Allow add to homescreen and app banner strings to be changed via variations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

Issue 2474353002: Allow add to homescreen and app banner strings to be changed via variations. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

index 6e1838652592320c32e3a7e6c01c768def64c169..6528eb9b05b13b396dd832c298c9ba62ed1202da 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java

@@ -15,6 +15,7 @@ import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.ContextUtils;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.banners.AppBannerManager;

import org.chromium.chrome.browser.banners.AppData;

import org.chromium.chrome.browser.widget.DualControlLayout;

@@ -174,7 +175,8 @@ public class AppBannerInfoBarAndroid extends ConfirmInfoBar implements View.OnCl

}

private static String getAddToHomescreenText() {

- return ContextUtils.getApplicationContext().getString(R.string.menu_add_to_homescreen);

+ return ContextUtils.getApplicationContext().getString(

+ AppBannerManager.getAppBannerLanguageOption());

}

@CalledByNative