Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4659)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2474353002: Allow add to homescreen and app banner strings to be changed via variations. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
index 4a34b9ad88af63f0d7f6a3cd618b7e787342fb95..59d4743b879b57375c9216e0a36f5ff23acb9df8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
@@ -16,6 +16,7 @@ import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.UrlConstants;
+import org.chromium.chrome.browser.banners.AppBannerManager;
import org.chromium.chrome.browser.bookmarks.BookmarkBridge;
import org.chromium.chrome.browser.download.DownloadUtils;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
@@ -162,10 +163,12 @@ public class AppMenuPropertiesDelegate {
// can not be added to the homescreen.
// 4.) If creating shortcuts it not supported by the current home screen.
MenuItem homescreenItem = menu.findItem(R.id.add_to_homescreen_id);
- boolean canAddShortcutToHomescreen =
- ShortcutHelper.isAddToHomeIntentSupported(mActivity);
- homescreenItem.setVisible(
- canAddShortcutToHomescreen && !isChromeScheme && !isFileScheme && !isIncognito);
+ boolean homescreenItemVisible = ShortcutHelper.isAddToHomeIntentSupported(mActivity)
+ && !isChromeScheme && !isFileScheme && !isIncognito;
+ if (homescreenItemVisible) {
+ homescreenItem.setTitle(AppBannerManager.getHomescreenLanguageOption());
+ }
+ homescreenItem.setVisible(homescreenItemVisible);
// Hide request desktop site on all chrome:// pages except for the NTP. Check request
// desktop site if it's activated on this page.
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698