Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2473993003: Delete IPC::ChannelPosix, IPC::ChannelWin and IPC::AttachmentBroker. (Closed)

Created:
4 years, 1 month ago by Sam McNally
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, anandc+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, jam, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mlamouri+watch-content_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, scf+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete IPC::ChannelPosix, IPC::ChannelWin and IPC::AttachmentBroker. BUG=659448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53 Cr-Commit-Position: refs/heads/master@{#430753}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -8666 lines) Patch
M blimp/test/fake_engine/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/test/fake_engine/fake_engine_app_tests.cc View 4 chunks +28 lines, -3 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/BUILD.gn View 9 chunks +0 lines, -37 lines 0 comments Download
M ipc/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
D ipc/attachment_broker.h View 1 chunk +0 lines, -177 lines 0 comments Download
D ipc/attachment_broker.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D ipc/attachment_broker_mac_unittest.cc View 1 chunk +0 lines, -1300 lines 0 comments Download
D ipc/attachment_broker_messages.h View 1 chunk +0 lines, -93 lines 0 comments Download
D ipc/attachment_broker_privileged.h View 1 chunk +0 lines, -131 lines 0 comments Download
D ipc/attachment_broker_privileged.cc View 1 chunk +0 lines, -171 lines 0 comments Download
D ipc/attachment_broker_privileged_mac.h View 1 chunk +0 lines, -220 lines 0 comments Download
D ipc/attachment_broker_privileged_mac.cc View 1 chunk +0 lines, -400 lines 0 comments Download
D ipc/attachment_broker_privileged_mac_unittest.cc View 1 chunk +0 lines, -428 lines 0 comments Download
D ipc/attachment_broker_privileged_win.h View 1 chunk +0 lines, -74 lines 0 comments Download
D ipc/attachment_broker_privileged_win.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D ipc/attachment_broker_privileged_win_unittest.cc View 1 chunk +0 lines, -668 lines 0 comments Download
D ipc/attachment_broker_unprivileged.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ipc/attachment_broker_unprivileged.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D ipc/attachment_broker_unprivileged_mac.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ipc/attachment_broker_unprivileged_mac.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D ipc/attachment_broker_unprivileged_win.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ipc/attachment_broker_unprivileged_win.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M ipc/brokerable_attachment.h View 2 chunks +0 lines, -37 lines 0 comments Download
M ipc/brokerable_attachment.cc View 1 chunk +2 lines, -40 lines 0 comments Download
D ipc/brokerable_attachment_mac.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D ipc/brokerable_attachment_win.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M ipc/handle_attachment_win.h View 2 chunks +2 lines, -6 lines 0 comments Download
M ipc/handle_attachment_win.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ipc/ipc_channel.h View 7 chunks +2 lines, -43 lines 0 comments Download
M ipc/ipc_channel_common.cc View 3 chunks +30 lines, -23 lines 0 comments Download
M ipc/ipc_channel_factory.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ipc/ipc_channel_mojo.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D ipc/ipc_channel_posix.h View 1 chunk +0 lines, -222 lines 0 comments Download
D ipc/ipc_channel_posix.cc View 1 chunk +0 lines, -1145 lines 0 comments Download
D ipc/ipc_channel_posix_unittest.cc View 1 chunk +0 lines, -506 lines 0 comments Download
M ipc/ipc_channel_reader.h View 6 chunks +3 lines, -49 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 8 chunks +6 lines, -135 lines 0 comments Download
M ipc/ipc_channel_reader_unittest.cc View 9 chunks +0 lines, -131 lines 0 comments Download
D ipc/ipc_channel_unittest.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D ipc/ipc_channel_win.h View 1 chunk +0 lines, -138 lines 0 comments Download
D ipc/ipc_channel_win.cc View 1 chunk +0 lines, -616 lines 0 comments Download
M ipc/ipc_message.h View 3 chunks +0 lines, -28 lines 0 comments Download
M ipc/ipc_message.cc View 7 chunks +0 lines, -78 lines 0 comments Download
M ipc/ipc_message_attachment_set.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/ipc_message_attachment_set.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D ipc/ipc_message_generator.h View 1 chunk +0 lines, -7 lines 0 comments Download
D ipc/ipc_message_generator.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M ipc/ipc_message_unittest.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +0 lines, -11 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M ipc/ipc_mojo_perftest.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D ipc/ipc_multiprocess_test.h View 1 chunk +0 lines, -26 lines 0 comments Download
D ipc/ipc_multiprocess_test.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M ipc/ipc_perftest_support.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_perftest_support.cc View 4 chunks +37 lines, -38 lines 0 comments Download
D ipc/ipc_perftests.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M ipc/ipc_test_base.h View 4 chunks +4 lines, -118 lines 0 comments Download
M ipc/ipc_test_base.cc View 2 chunks +8 lines, -157 lines 0 comments Download
M ipc/mach_port_attachment_mac.h View 2 chunks +2 lines, -8 lines 0 comments Download
M ipc/mach_port_attachment_mac.cc View 2 chunks +2 lines, -4 lines 0 comments Download
D ipc/placeholder_brokerable_attachment.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ipc/placeholder_brokerable_attachment.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 55 (44 generated)
Sam McNally
4 years, 1 month ago (2016-11-07 00:10:44 UTC) #37
Ken Rockot(use gerrit already)
LGTM - Wow, that's a lot of code!
4 years, 1 month ago (2016-11-08 00:38:05 UTC) #38
Sam McNally
+thestig for //chrome +nyquist for //blimp
4 years, 1 month ago (2016-11-08 01:51:21 UTC) #40
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-08 01:53:20 UTC) #41
nyquist
blimp lgtm
4 years, 1 month ago (2016-11-08 05:04:01 UTC) #42
Sam McNally
TBR: piman for //content, //gpu and //ppapi mseaborn for //components/nacl
4 years, 1 month ago (2016-11-08 20:06:45 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473993003/120001
4 years, 1 month ago (2016-11-08 20:08:20 UTC) #47
Mark Seaborn
On 2016/11/08 20:06:45, Sam McNally wrote: > TBR: > piman for //content, //gpu and //ppapi ...
4 years, 1 month ago (2016-11-08 20:14:54 UTC) #48
piman
lgtm
4 years, 1 month ago (2016-11-08 21:25:26 UTC) #50
commit-bot: I haz the power
Committed patchset #1 (id:120001)
4 years, 1 month ago (2016-11-08 23:25:14 UTC) #53
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:38:22 UTC) #55
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/beeed368eb1ac5c097162ad4f6e36d012ee88a53
Cr-Commit-Position: refs/heads/master@{#430753}

Powered by Google App Engine
This is Rietveld 408576698