Remove obsolete methods from IPC::Channel and related classes.

Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG=659448
Committed: https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468
Cr-Commit-Position: refs/heads/master@{#431036}

[Sam McNally, 2016-11-04 05:58:19]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 05:58:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:11:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 06:11:34]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Sam McNally, 2016-11-04 08:42:03]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 08:42:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 08:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 08:55:09]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Sam McNally, 2016-11-04 09:07:29]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 09:07:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 09:20:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 09:20:16]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Sam McNally, 2016-11-04 09:41:27]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 09:41:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 09:54:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 09:54:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2016-11-04 10:08:52]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 10:09:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-04 10:17:11]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 10:17:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 11:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 11:26:47]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-06 23:33:20]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-06 23:33:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 00:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 00:58:09]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-08 02:21:37]

Description was changed from

==========
Remove the POSIX-specific methods from IPC::Channel.

BUG=659448
==========

to

==========
Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG=659448
==========

[Sam McNally, 2016-11-08 02:22:00]

Description was changed from

==========
Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG=659448
==========

to

==========
Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG=659448
==========

[Sam McNally, 2016-11-08 02:22:22]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-11-08 02:22:24]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-11-08 02:22:26]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-11-08 02:22:28]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-11-08 02:22:30]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-11-08 02:22:35]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-11-08 02:22:38]

Patchset #1 (id:120001) has been deleted

[Sam McNally, 2016-11-08 02:45:10]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 02:45:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-08 02:45:58]

Patchset #1 (id:140001) has been deleted

[commit-bot: I haz the power, 2016-11-08 05:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 05:27:41]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-08 07:18:59]

sammc@chromium.org changed reviewers:
+ nasko@chromium.org, rockot@chromium.org

[Sam McNally, 2016-11-08 07:19:00]

+nasko for //content and security review of the
SandboxedProcessLauncherDelegate-derived classes in *_process_host(_impl).cc

+rockot for //ipc

[Ken Rockot(use gerrit already), 2016-11-08 18:36:37]

lgtm

[nasko, 2016-11-08 21:42:35]

nasko@chromium.org changed reviewers:
+ palmer@chromium.org

[nasko, 2016-11-08 21:42:36]

Switching reviewer with palmer@, as he has more knowledge of this area than
myself.

[nasko, 2016-11-08 21:42:49]

nasko@chromium.org changed reviewers:
- nasko@chromium.org

[palmer, 2016-11-08 23:12:15]

lgtm

[Sam McNally, 2016-11-09 00:18:09]

sammc@chromium.org changed reviewers:
+ mseaborn@chromium.org, nasko@chromium.org, raymes@chromium.org,
rjkroege@chromium.org, tsepez@chromium.org

[Sam McNally, 2016-11-09 00:18:10]

+nasko for //content

+tsepez for //tools/ipc_fuzzer

+rjkroege for //ui/ozone

+raymes for //ppapi/proxy

+mseaborn for //components/nacl

[Tom Sepez, 2016-11-09 00:31:00]

https://codereview.chromium.org/2476883002/diff/160001/ipc/ipc_channel.h
File ipc/ipc_channel.h (left):

https://codereview.chromium.org/2476883002/diff/160001/ipc/ipc_channel.h#oldc...
ipc/ipc_channel.h:266: // Generates a channel ID that, if passed to the client
as a shared secret,
This was used to avoid a fairly serious bug where a compromised process could
race the creation of a more privileged one, and squat on the end of its pipe. 
Remind me again of how we avoid this issue under mojo?

[Mark Seaborn, 2016-11-09 00:39:00]

On 2016/11/09 00:18:10, Sam McNally wrote:
> +mseaborn for //components/nacl

LGTM for that.

[rjkroege, 2016-11-09 01:21:44]

ozone: lgtm

[raymes, 2016-11-09 01:33:28]

ppapi rs lgtm

[Sam McNally, 2016-11-09 05:06:30]

https://codereview.chromium.org/2476883002/diff/160001/ipc/ipc_channel.h
File ipc/ipc_channel.h (left):

https://codereview.chromium.org/2476883002/diff/160001/ipc/ipc_channel.h#oldc...
ipc/ipc_channel.h:266: // Generates a channel ID that, if passed to the client
as a shared secret,
On 2016/11/09 00:31:00, Tom Sepez wrote:
> This was used to avoid a fairly serious bug where a compromised process could
> race the creation of a more privileged one, and squat on the end of its pipe. 
> Remind me again of how we avoid this issue under mojo?

In most cases, pipe names aren't used: for normal processes FDs/HANDLEs are
passed/inherited at launch. I'm not sure what we do for the named pipes used
with elevated processes.

[Tom Sepez, 2016-11-09 17:49:07]

> In most cases, pipe names aren't used: for normal processes FDs/HANDLEs are
> passed/inherited at launch. I'm not sure what we do for the named pipes used
> with elevated processes.
Looks like in your other CL, that we've removed the "named" usage.  So I think
this is OK, given that I need to circle back and check on what mojo itself is
doing nowadays.  LGTM.

[nasko, 2016-11-09 18:38:10]

content/ rubberstamp LGTM based on palmer@'s and tsepez@'s reviews. Just one
question about formatting.

https://codereview.chromium.org/2476883002/diff/160001/content/browser/gpu/gp...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/2476883002/diff/160001/content/browser/gpu/gp...
content/browser/gpu/gpu_process_host.cc:210: }
Is this formatted using "git cl format"?

[Sam McNally, 2016-11-09 20:21:39]

https://codereview.chromium.org/2476883002/diff/160001/content/browser/gpu/gp...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/2476883002/diff/160001/content/browser/gpu/gp...
content/browser/gpu/gpu_process_host.cc:210: }
On 2016/11/09 18:38:10, nasko wrote:
> Is this formatted using "git cl format"?

Yes.

[Sam McNally, 2016-11-09 20:22:13]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-11-09 20:22:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 21:24:44]

Description was changed from

==========
Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG=659448
==========

to

==========
Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG=659448
==========

[commit-bot: I haz the power, 2016-11-09 21:24:46]

Committed patchset #1 (id:160001)

[commit-bot: I haz the power, 2016-11-09 21:37:22]

Description was changed from

==========
Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG=659448
==========

to

==========
Remove obsolete methods from IPC::Channel and related classes.

This removes GetSelfPID(), GetClientFileDescriptor() and
TakeClientFileDescriptor(), along with corresponding methods on
content::ChildProcessHost, content::SandboxedProcessLauncherDelegate,
NaClIPCAdapter and ppapi::proxy::ProxyChannel. This also removes the
unused IPC descriptors kPrimaryIPCChannel and kStatsTableSharedMemFd.

BUG=659448

Committed: https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468
Cr-Commit-Position: refs/heads/master@{#431036}
==========

[commit-bot: I haz the power, 2016-11-09 21:37:24]

Patchset 1 (id:??) landed as
https://crrev.com/19eb6f7cc2ca4b1064781d73f6f74a9d114a9468
Cr-Commit-Position: refs/heads/master@{#431036}