Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: ipc/ipc_channel_factory.cc

Issue 2473993003: Delete IPC::ChannelPosix, IPC::ChannelWin and IPC::AttachmentBroker. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_common.cc ('k') | ipc/ipc_channel_mojo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_factory.cc
diff --git a/ipc/ipc_channel_factory.cc b/ipc/ipc_channel_factory.cc
index 50c00c05c88f01418724f74419b94def87e2fc4f..274989f0bc32f3d693e36d2e73b45ef6bad27f8f 100644
--- a/ipc/ipc_channel_factory.cc
+++ b/ipc/ipc_channel_factory.cc
@@ -19,17 +19,17 @@ class PlatformChannelFactory : public ChannelFactory {
const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner)
: handle_(handle), mode_(mode), ipc_task_runner_(ipc_task_runner) {}
- std::string GetName() const override {
- return handle_.name;
- }
+ std::string GetName() const override { return ""; }
std::unique_ptr<Channel> BuildChannel(Listener* listener) override {
- if (handle_.mojo_handle.is_valid()) {
- return ChannelMojo::Create(
- mojo::ScopedMessagePipeHandle(handle_.mojo_handle), mode_, listener,
- ipc_task_runner_);
- }
+#if defined(OS_NACL_SFI)
return Channel::Create(handle_, mode_, listener);
+#else
+ DCHECK(handle_.is_mojo_channel_handle());
+ return ChannelMojo::Create(
+ mojo::ScopedMessagePipeHandle(handle_.mojo_handle), mode_, listener,
+ ipc_task_runner_);
+#endif
}
scoped_refptr<base::SingleThreadTaskRunner> GetIPCTaskRunner() override {
« no previous file with comments | « ipc/ipc_channel_common.cc ('k') | ipc/ipc_channel_mojo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698