Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2468113008: Revert of chromeos: Move ownership of system tray width from chrome to ash (Closed)

Created:
4 years, 1 month ago by James Cook
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromeos: Move ownership of system tray width from chrome to ash (patchset #3 id:40001 of https://codereview.chromium.org/2448373002/ ) Reason for revert: This is breaking one of the translation console tools, see http://crbug.com/660912 We'll need to introduce a new file ash_locale_settings.grd (similar to ui/strings/app_locale_settings.grd) that the translation console tools can skip. Original issue's description: > chromeos: Move ownership of system tray width from chrome to ash > > The system tray menu width is customized per locale. Ash should own this > information, not chrome. Move the string that sets the width from > chrome/app/resources/locale_settings.grd to ash/common/strings/ash_strings.grd. > > This eliminates the method ash::SystemTrayDelegate::GetSystemTrayMenuWidth() > method so I don't have to refactor it as part of mustash. > > BUG=647412 > TEST=Run chrome with --lang=de, see system menu get wider than in English > > Committed: https://crrev.com/cb628c9a68535cd0c7925beae32fada248f9bfff > Cr-Commit-Position: refs/heads/master@{#427703} TBR=sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=647412 Committed: https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e Cr-Commit-Position: refs/heads/master@{#429600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -62 lines) Patch
M ash/ash_strings.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/common/strings/ash_strings_am.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ar.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_bg.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_bn.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ca.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_cs.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_da.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_de.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_el.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_es.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_es-419.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_et.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_fa.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_fi.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_fil.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_fr.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_gu.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_hi.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_hr.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_hu.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_id.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_it.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_iw.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ja.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_kn.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ko.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_lt.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_lv.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ml.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_mr.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ms.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_nl.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_no.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_pl.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_pt-BR.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_pt-PT.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ro.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ru.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_sk.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_sl.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_sr.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_sv.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_sw.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_ta.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_te.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_th.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_tr.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_uk.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_vi.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_zh-CN.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/strings/ash_strings_zh-TW.xtb View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/tray/default_system_tray_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/tray/default_system_tray_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/tray/system_tray_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings.grd View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_am.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ar.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_bg.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_bn.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ca.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_cs.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_da.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_de.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_el.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_es.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_es-419.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_et.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fa.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fake-bidi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fil.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_fr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_gu.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_he.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_hi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_hr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_hu.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_id.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_it.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ja.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_kn.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ko.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_lt.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_lv.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ml.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_mr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ms.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_nb.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_nl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_pl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_pt-BR.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_pt-PT.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ro.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ru.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sk.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sl.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sv.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_sw.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_ta.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_te.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_th.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_tr.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_uk.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_vi.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-CN.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-TW.xtb View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
James Cook
Created Revert of chromeos: Move ownership of system tray width from chrome to ash
4 years, 1 month ago (2016-11-03 05:05:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468113008/1
4 years, 1 month ago (2016-11-03 05:05:56 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-03 07:06:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468113008/1
4 years, 1 month ago (2016-11-03 15:42:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 15:53:20 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 16:11:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/239c1372ce403786415a6a9825b11c2a859d729e
Cr-Commit-Position: refs/heads/master@{#429600}

Powered by Google App Engine
This is Rietveld 408576698