Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2463673004: [inspector_protocol] Support fall through. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[inspector_protocol] Support fall through. BUG=none

Patch Set 1 #

Patch Set 2 : templates #

Patch Set 3 : example domain converted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -256 lines) Patch
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-media-text-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-multiple-style-texts-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/css/css-set-rule-selector-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/report-protocol-errors-expected.txt View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 2 11 chunks +45 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 2 1 chunk +8 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp View 1 2 5 chunks +56 lines, -72 lines 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 2 4 chunks +7 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/inspector_protocol.gni View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/inspector_protocol/inspector_protocol.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/inspector_protocol/lib/BackendCallback_h.template View 1 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/inspector_protocol/lib/DispatcherBase_cpp.template View 6 chunks +82 lines, -30 lines 0 comments Download
M third_party/inspector_protocol/lib/DispatcherBase_h.template View 1 5 chunks +42 lines, -19 lines 0 comments Download
M third_party/inspector_protocol/lib/Forward_h.template View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 1 6 chunks +55 lines, -34 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_h.template View 1 2 2 chunks +43 lines, -15 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (5 generated)
dgozman
WDYT, guys?
4 years, 1 month ago (2016-10-31 18:08:14 UTC) #6
kozy
4 years, 1 month ago (2016-10-31 21:57:32 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698