Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h

Issue 2463673004: [inspector_protocol] Support fall through. (Closed)
Patch Set: example domain converted Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h
diff --git a/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h b/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h
index 7dc187092db80a5ada5b5bc5585d578f9508c5c2..7e235f088765b50749847c5bd70c543b27f01e99 100644
--- a/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h
+++ b/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h
@@ -69,26 +69,23 @@ class MODULES_EXPORT InspectorDOMStorageAgent final
void restore() override;
// protocol::Dispatcher::DOMStorageCommandHandler overrides.
- void enable(ErrorString*) override;
- void disable(ErrorString*) override;
- void getDOMStorageItems(
- ErrorString*,
+ Response enable() override;
+ Response disable() override;
+ Response getDOMStorageItems(
std::unique_ptr<protocol::DOMStorage::StorageId> in_storageId,
std::unique_ptr<protocol::Array<protocol::Array<String>>>* out_entries)
override;
- void setDOMStorageItem(
- ErrorString*,
+ Response setDOMStorageItem(
std::unique_ptr<protocol::DOMStorage::StorageId> in_storageId,
const String& in_key,
const String& in_value) override;
- void removeDOMStorageItem(
- ErrorString*,
+ Response removeDOMStorageItem(
std::unique_ptr<protocol::DOMStorage::StorageId> in_storageId,
const String& in_key) override;
- StorageArea* findStorageArea(ErrorString*,
- std::unique_ptr<protocol::DOMStorage::StorageId>,
- LocalFrame*&);
+ Response findStorageArea(std::unique_ptr<protocol::DOMStorage::StorageId>,
+ LocalFrame*&,
+ StorageArea*&);
std::unique_ptr<protocol::DOMStorage::StorageId> storageId(
SecurityOrigin*,
bool isLocalStorage);

Powered by Google App Engine
This is Rietveld 408576698