Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: third_party/inspector_protocol/CodeGenerator.py

Issue 2463673004: [inspector_protocol] Support fall through. (Closed)
Patch Set: example domain converted Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/inspector_protocol/CodeGenerator.py
diff --git a/third_party/inspector_protocol/CodeGenerator.py b/third_party/inspector_protocol/CodeGenerator.py
index 97eda508091bf297c9f9a711437ee93ca3f355cd..5c15d96443315c68637b99d90a344be8ce84ce0e 100644
--- a/third_party/inspector_protocol/CodeGenerator.py
+++ b/third_party/inspector_protocol/CodeGenerator.py
@@ -329,6 +329,11 @@ def resolve_type(protocol, prop):
return protocol.type_definitions[prop["type"]]
+def new_style(domain):
+ domains = ["DOMStorage"]
+ return domain["domain"] in domains
+
+
def join_arrays(dict, keys):
result = []
for key in keys:
@@ -339,7 +344,7 @@ def join_arrays(dict, keys):
def has_disable(commands):
for command in commands:
- if command["name"] == "disable":
+ if command["name"] == "disable" and (not ("handlers" in command) or "renderer" in command["handlers"]):
return True
return False
@@ -421,6 +426,7 @@ def main():
"type_definition": functools.partial(type_definition, protocol),
"has_disable": has_disable,
"format_include": format_include,
+ "new_style": new_style,
}
if domain["domain"] in protocol.generate_domains:
@@ -448,7 +454,6 @@ def main():
"ValueConversions_h.template",
"Maybe_h.template",
"Array_h.template",
- "BackendCallback_h.template",
"DispatcherBase_h.template",
"Parser_h.template",
]

Powered by Google App Engine
This is Rietveld 408576698