Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2463293002: [DevTools] migrate InspectorLayerTreeAgent to new style (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] migrate InspectorLayerTreeAgent to new style BUG=none R=dgozman@chromium.org Committed: https://crrev.com/22e352dff64bed32b56cae355282f198c0ae01db Cr-Commit-Position: refs/heads/master@{#429291}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed cpmments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -114 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 2 chunks +18 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 6 chunks +78 lines, -86 lines 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/README.chromium View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2467933002 Patch 20001

Dependent Patchsets:

Issue 2468803002 Patch 60001

Messages

Total messages: 11 (5 generated)
kozy
Dmitry, please take a look!
4 years, 1 month ago (2016-11-01 15:07:12 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2463293002/diff/1/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp (right): https://codereview.chromium.org/2463293002/diff/1/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp#newcode363 third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp:363: return Response::Error("No draws content in layer"); Layer does ...
4 years, 1 month ago (2016-11-01 18:09:13 UTC) #3
kozy
All done, thanks! https://codereview.chromium.org/2463293002/diff/1/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp File third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp (right): https://codereview.chromium.org/2463293002/diff/1/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp#newcode363 third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp:363: return Response::Error("No draws content in layer"); ...
4 years, 1 month ago (2016-11-02 04:33:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463293002/20001
4 years, 1 month ago (2016-11-02 14:41:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 16:12:17 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 16:20:46 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/22e352dff64bed32b56cae355282f198c0ae01db
Cr-Commit-Position: refs/heads/master@{#429291}

Powered by Google App Engine
This is Rietveld 408576698