Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h

Issue 2463673004: [inspector_protocol] Support fall through. (Closed)
Patch Set: example domain converted Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h b/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
index 9f552d3198f24d1c13cbff0d1a0eaae9ff42497a..af556bb1dc1bcdf508da45422100b93247448ea0 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h
@@ -44,6 +44,7 @@ class LocalFrame;
using protocol::ErrorString;
using protocol::Maybe;
+using protocol::Response;
class CORE_EXPORT InspectorAgent
: public GarbageCollectedFinalized<InspectorAgent> {
@@ -85,11 +86,8 @@ class InspectorBaseAgent : public InspectorAgent,
}
}
- void disable(ErrorString*) override {}
-
void dispose() override {
- ErrorString error;
- disable(&error);
+ DomainMetainfo::BackendClass::disableMe(this);
m_frontend.reset();
m_state = nullptr;
m_instrumentingAgents = nullptr;

Powered by Google App Engine
This is Rietveld 408576698