Move printing defines to buildflag system.

Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

One define about printing is removed from Blink. This function seems only to
be called by the embedder, and printing code is compiled into Blink either
way. The define seems to not be doing much. if the embedder doesn't want to
print, they should not call the print function.

There is a custom hack for the .rc file due to resource compiler preprocessor limitations.

R=dbeam@chromium.org, dcheng@chromium.org, thestig@chromium.org, thestig, dcheng (third_party/WebKit)
TBR=dbeam (webui), jschuh (ipc messages)

Committed: https://chromium.googlesource.com/chromium/src/+/65f951ca1dc8c6b3fc5b2dc32e44b4e28a3b86e2

[brettw, 2016-10-28 21:33:55]

Description was changed from

==========
Move printing defines to buildflaag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).
==========

to

==========
Move printing defines to buildflaag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

R=thestig
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

[brettw, 2016-10-28 21:33:56]

brettw@chromium.org changed reviewers:
+ dbeam@chromium.org, jschuh@chromium.org, thestig@chromium.org

[brettw, 2016-10-28 21:34:06]

Description was changed from

==========
Move printing defines to buildflaag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

R=thestig
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

to

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

R=thestig
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

[brettw, 2016-10-28 21:35:58]

Missing file

[brettw, 2016-10-28 21:35:59]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 21:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 21:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 21:48:37]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Lei Zhang, 2016-10-28 21:49:49]

lgtm

https://codereview.chromium.org/2458833005/diff/20001/chrome/common/features.gni
File chrome/common/features.gni (right):

https://codereview.chromium.org/2458833005/diff/20001/chrome/common/features....
chrome/common/features.gni:71: _enable_printing = enable_basic_printing ||
enable_print_preview
Does the leading underscore mean it's a local variable?

[brettw, 2016-10-28 22:20:54]

https://codereview.chromium.org/2458833005/diff/20001/chrome/common/features.gni
File chrome/common/features.gni (right):

https://codereview.chromium.org/2458833005/diff/20001/chrome/common/features....
chrome/common/features.gni:71: _enable_printing = enable_basic_printing ||
enable_print_preview
On 2016/10/28 21:49:49, Lei Zhang wrote:
> Does the leading underscore mean it's a local variable?

Yes, it won't get exposed to files that import this one.

[brettw, 2016-10-28 22:23:59]

Fix Windows

[brettw, 2016-10-28 22:23:59]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-28 22:24:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2458833005/#ps40001
(title: "Fix Windows")

[commit-bot: I haz the power, 2016-10-28 22:24:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 22:28:16]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-10-28 22:31:20]

Merge

[brettw, 2016-10-28 22:31:20]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-28 22:31:21]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2458833005/#ps60001
(title: "Merge")

[commit-bot: I haz the power, 2016-10-28 22:32:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 23:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 23:12:09]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-10-28 23:13:49]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-28 23:14:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 23:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 23:24:04]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Lei Zhang, 2016-10-28 23:25:57]

On 2016/10/28 23:24:04, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

There was redness on the main waterfall. Probably need to wait for all the
current try jobs to finish before trying the CQ again.

[brettw, 2016-10-29 04:37:54]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-10-29 04:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 04:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 04:42:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-10-31 16:52:12]

Merge

[brettw, 2016-10-31 16:52:15]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-31 16:52:16]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2458833005/#ps80001
(title: "Merge")

[commit-bot: I haz the power, 2016-10-31 16:52:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 17:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 17:27:13]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[brettw, 2016-10-31 19:56:04]

RC fix

[brettw, 2016-10-31 19:56:05]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-31 19:56:06]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2458833005/#ps100001
(title: "RC fix")

[commit-bot: I haz the power, 2016-10-31 19:56:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-10-31 19:59:22]

Description was changed from

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

R=thestig
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

to

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=thestig
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

[brettw, 2016-10-31 20:00:10]

I had to add a hack for the buildflag use in chrome_dll.rc since rc fails on any
identifier longer than 31 characters. These defines in .rc files seem very
uncommon.

[Lei Zhang, 2016-10-31 20:07:35]

On 2016/10/31 20:00:10, brettw (ping on IM after 24h) wrote:
> I had to add a hack for the buildflag use in chrome_dll.rc since rc fails on
any
> identifier longer than 31 characters. These defines in .rc files seem very
> uncommon.

Ack.

[commit-bot: I haz the power, 2016-10-31 21:55:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:56:00]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dan Beam, 2016-11-01 06:21:53]

rs lgtm but should there be included for build/buildflag.h for BUILDFLAG() +
IWYU?

[Dan Beam, 2016-11-01 06:22:06]

should there be includes*

[brettw, 2016-11-01 21:56:08]

Merge fix, Blink

[brettw, 2016-11-01 21:58:09]

Description was changed from

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=thestig
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

to

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

One define about printing is removed from Blink. This function seems only to
be called by the embedder, and printing code is compiled into Blink either
way. The define seems to not be doing much. if the embedder doesn't want to
print, they should not call the print function.

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=thestig
T=dcheng (third_party/WebKit)
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

[brettw, 2016-11-01 21:58:21]

Description was changed from

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

One define about printing is removed from Blink. This function seems only to
be called by the embedder, and printing code is compiled into Blink either
way. The define seems to not be doing much. if the embedder doesn't want to
print, they should not call the print function.

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=thestig
T=dcheng (third_party/WebKit)
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

to

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

One define about printing is removed from Blink. This function seems only to
be called by the embedder, and printing code is compiled into Blink either
way. The define seems to not be doing much. if the embedder doesn't want to
print, they should not call the print function.

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=thestig
R=dcheng (third_party/WebKit)
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

[brettw, 2016-11-01 21:58:49]

brettw@chromium.org changed reviewers:
+ dcheng@chromium.org

[brettw, 2016-11-01 21:58:50]

+dcheng for the define removal in third_party/WebKit.

[brettw, 2016-11-01 21:58:59]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 21:59:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-01 22:08:10]

On 2016/11/01 21:58:50, brettw (ping on IM after 24h) wrote:
> +dcheng for the define removal in third_party/WebKit.

Probably ok since the only real callers are in PrintWebViewHelper, which is not
instantiated when printing is disabled.

[brettw, 2016-11-01 22:11:46]

On 2016/11/01 06:21:53, Dan Beam wrote:
> rs lgtm but should there be included for build/buildflag.h for BUILDFLAG() +
> IWYU?

The generated headers always contain what you need to use the build flags
(buildflag.h is an internal implementation detail of the build flag system).

[dcheng, 2016-11-01 22:13:45]

Blink LGTM

[commit-bot: I haz the power, 2016-11-01 23:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 23:00:58]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-11-02 16:39:07]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-02 16:39:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2458833005/#ps120001
(title: "Merge fix, Blink")

[commit-bot: I haz the power, 2016-11-02 16:39:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 18:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 18:40:36]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-11-03 05:39:07]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 05:39:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 05:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 05:43:07]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2016-11-03 06:25:16]

Merge

[brettw, 2016-11-03 06:25:17]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-11-03 06:25:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dbeam@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2458833005/#ps140001
(title: "Merge")

[commit-bot: I haz the power, 2016-11-03 06:25:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 08:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:26:02]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brettw, 2016-11-03 15:35:35]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-03 15:35:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:46:24]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[brettw, 2016-11-03 21:38:18]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:39:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:09:37]

Description was changed from

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

One define about printing is removed from Blink. This function seems only to
be called by the embedder, and printing code is compiled into Blink either
way. The define seems to not be doing much. if the embedder doesn't want to
print, they should not call the print function.

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=thestig
R=dcheng (third_party/WebKit)
TBR=dbeam (webui)
TBR=jschuh (ipc messages)
==========

to

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

One define about printing is removed from Blink. This function seems only to
be called by the embedder, and printing code is compiled into Blink either
way. The define seems to not be doing much. if the embedder doesn't want to
print, they should not call the print function.

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=dbeam@chromium.org, dcheng@chromium.org, thestig@chromium.org, thestig, dcheng
(third_party/WebKit)
TBR=dbeam (webui), jschuh (ipc messages)

Committed: https://crrev.com/65f951ca1dc8c6b3fc5b2dc32e44b4e28a3b86e2
Cr-Commit-Position: refs/heads/master@{#429707}
==========

[commit-bot: I haz the power, 2016-11-03 22:09:39]

Patchset 8 (id:??) landed as
https://crrev.com/65f951ca1dc8c6b3fc5b2dc32e44b4e28a3b86e2
Cr-Commit-Position: refs/heads/master@{#429707}

[brettw, 2016-11-03 22:10:46]

Description was changed from

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

One define about printing is removed from Blink. This function seems only to
be called by the embedder, and printing code is compiled into Blink either
way. The define seems to not be doing much. if the embedder doesn't want to
print, they should not call the print function.

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=dbeam@chromium.org, dcheng@chromium.org, thestig@chromium.org, thestig, dcheng
(third_party/WebKit)
TBR=dbeam (webui), jschuh (ipc messages)

Committed: https://crrev.com/65f951ca1dc8c6b3fc5b2dc32e44b4e28a3b86e2
Cr-Commit-Position: refs/heads/master@{#429707}
==========

to

==========
Move printing defines to buildflag system.

Removes the build flags in //build/config/features.gni and puts them in a new
file //printing/features/features.gni. A "features" target in that directory
converts these to a BUILDFLAG header. Update users of define to use the new
include, and check BUILDFLAG(...) instead of defined(...).

One define about printing is removed from Blink. This function seems only to
be called by the embedder, and printing code is compiled into Blink either
way. The define seems to not be doing much. if the embedder doesn't want to
print, they should not call the print function.

There is a custom hack for the .rc file due to resource compiler preprocessor
limitations.

R=dbeam@chromium.org, dcheng@chromium.org, thestig@chromium.org, thestig, dcheng
(third_party/WebKit)
TBR=dbeam (webui), jschuh (ipc messages)

Committed:
https://chromium.googlesource.com/chromium/src/+/65f951ca1dc8c6b3fc5b2dc32e44...
==========

[brettw, 2016-11-03 22:10:49]

Committed patchset #8 (id:140001) manually as
65f951ca1dc8c6b3fc5b2dc32e44b4e28a3b86e2 (presubmit successful).