Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2358)

Unified Diff: build/config/BUILD.gn

Issue 2458833005: Move printing defines to buildflag system. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 3b2ce6e90c53ee4a39f43c50ef65bbf0fbaa4b34..fd05dfd9e689f33ba76cedba6c94c92bb9cd100a 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -71,25 +71,6 @@ config("feature_flags") {
if (enable_pdf) {
defines += [ "ENABLE_PDF=1" ]
}
- if (enable_basic_printing || enable_print_preview) {
- # Convenience define for ENABLE_BASIC_PRINTING || ENABLE_PRINT_PREVIEW.
- defines += [ "ENABLE_PRINTING=1" ]
- if (enable_basic_printing) {
- # Enable basic printing support and UI.
- defines += [ "ENABLE_BASIC_PRINTING=1" ]
- }
- if (enable_print_preview) {
- # Enable printing with print preview.
- # Can be defined without ENABLE_BASIC_PRINTING.
- defines += [ "ENABLE_PRINT_PREVIEW=1" ]
- }
- if ((enable_basic_printing && is_win) || enable_print_preview) {
- # Windows basic printing or print preview requires pdf enabled.
- assert(enable_pdf,
- "Windows basic printing or print preview needs pdf: " +
- "set enable_pdf=true.")
- }
- }
if (enable_spellcheck) {
defines += [ "ENABLE_SPELLCHECK=1" ]
}
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698