Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2480)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/chrome_dll.rc

Issue 2458833005: Move printing defines to buildflag system. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/BUILD.gn ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_dll.rc
diff --git a/chrome/app/chrome_dll.rc b/chrome/app/chrome_dll.rc
index fa079d0dd9af901e73fd0060a39c3cf8211edc1e..becda38661cd8d28a7e9c83ead649568d634c93e 100644
--- a/chrome/app/chrome_dll.rc
+++ b/chrome/app/chrome_dll.rc
@@ -33,9 +33,12 @@ LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
// pick those up in the WM_APPCOMMAND message.
IDR_MAINFRAME ACCELERATORS
BEGIN
-#if defined(ENABLE_BASIC_PRINTING)
+// This really should be using the buildflag but the resource compiler fails on
+// macro functions longer than 31 chars which this command produces. The BUILD
+// sets this regular define for this target only for this line to consume.
+#ifdef ENABLE_BASIC_PRINTING_FOR_RC // #if BUILDFLAG(ENABLE_BASIC_PRINTING)
"P", IDC_BASIC_PRINT, VIRTKEY, CONTROL, SHIFT
-#endif // ENABLE_BASIC_PRINTING
+#endif // ENABLE_BASIC_PRINTING_FOR_RC
VK_LEFT, IDC_BACK, VIRTKEY, ALT
VK_BACK, IDC_BACK, VIRTKEY
"D", IDC_BOOKMARK_PAGE, VIRTKEY, CONTROL
« no previous file with comments | « chrome/app/BUILD.gn ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698