Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/common/features.gni

Issue 2458833005: Move printing defines to buildflag system. (Closed)
Patch Set: Missing file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/common_message_generator.h ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/config/chromecast_build.gni") 6 import("//build/config/chromecast_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//printing/features/features.gni")
9 10
10 # Please keep features in alphabetical order. 11 # Please keep features in alphabetical order.
11 declare_args() { 12 declare_args() {
12 # Whether the Java UI is being used (Java infobars and popups, Java native 13 # Whether the Java UI is being used (Java infobars and popups, Java native
13 # settings and first run experience, sign-in etc.). 14 # settings and first run experience, sign-in etc.).
14 # Default to true if compiling for android, but allow this being overriden 15 # Default to true if compiling for android, but allow this being overriden
15 # through the environment. 16 # through the environment.
16 android_java_ui = is_android 17 android_java_ui = is_android
17 18
18 enable_app_list = is_chromeos 19 enable_app_list = is_chromeos
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 enable_xpc_notifications = false 61 enable_xpc_notifications = false
61 62
62 # Indicates if the build is using PGO. 63 # Indicates if the build is using PGO.
63 pgo_build = chrome_pgo_phase > 0 64 pgo_build = chrome_pgo_phase > 0
64 65
65 # Use vulcanized HTML/CSS/JS resources to speed up WebUI (chrome://) 66 # Use vulcanized HTML/CSS/JS resources to speed up WebUI (chrome://)
66 # pages. https://github.com/polymer/vulcanize 67 # pages. https://github.com/polymer/vulcanize
67 use_vulcanize = true 68 use_vulcanize = true
68 } 69 }
69 70
71 _enable_printing = enable_basic_printing || enable_print_preview
Lei Zhang 2016/10/28 21:49:49 Does the leading underscore mean it's a local vari
brettw 2016/10/28 22:20:54 Yes, it won't get exposed to files that import thi
72
70 chrome_grit_defines = [ 73 chrome_grit_defines = [
71 "enable_app_list=$enable_app_list", 74 "enable_app_list=$enable_app_list",
72 "enable_background=$enable_background", 75 "enable_background=$enable_background",
73 "enable_google_now=$enable_google_now", 76 "enable_google_now=$enable_google_now",
74 "enable_hangout_services_extension=$enable_hangout_services_extension", 77 "enable_hangout_services_extension=$enable_hangout_services_extension",
75 "enable_hotwording=$enable_hotwording", 78 "enable_hotwording=$enable_hotwording",
79 "enable_print_preview=$enable_print_preview",
80 "enable_printing=$_enable_printing",
76 "enable_service_discovery=$enable_service_discovery", 81 "enable_service_discovery=$enable_service_discovery",
77 "enable_vr_shell=$enable_vr_shell", 82 "enable_vr_shell=$enable_vr_shell",
78 "enable_webvr=$enable_webvr", 83 "enable_webvr=$enable_webvr",
79 "safe_browsing_mode=$safe_browsing_mode", 84 "safe_browsing_mode=$safe_browsing_mode",
80 "use_vulcanize=$use_vulcanize", 85 "use_vulcanize=$use_vulcanize",
81 ] 86 ]
OLDNEW
« no previous file with comments | « chrome/common/common_message_generator.h ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698