Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/app/chrome_dll.rc

Issue 2458833005: Move printing defines to buildflag system. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/BUILD.gn ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Microsoft Visual C++ generated resource script. 1 // Microsoft Visual C++ generated resource script.
2 // 2 //
3 #include "chrome_dll_resource.h" 3 #include "chrome_dll_resource.h"
4 #include "chrome_command_ids.h" 4 #include "chrome_command_ids.h"
5 5
6 #define APSTUDIO_READONLY_SYMBOLS 6 #define APSTUDIO_READONLY_SYMBOLS
7 ///////////////////////////////////////////////////////////////////////////// 7 /////////////////////////////////////////////////////////////////////////////
8 // 8 //
9 // Generated from the TEXTINCLUDE 2 resource. 9 // Generated from the TEXTINCLUDE 2 resource.
10 // 10 //
(...skipping 15 matching lines...) Expand all
26 26
27 ///////////////////////////////////////////////////////////////////////////// 27 /////////////////////////////////////////////////////////////////////////////
28 // 28 //
29 // Accelerator 29 // Accelerator
30 // 30 //
31 31
32 // Note that we don't handle any of the VK_BROWSER_* commands here. We will 32 // Note that we don't handle any of the VK_BROWSER_* commands here. We will
33 // pick those up in the WM_APPCOMMAND message. 33 // pick those up in the WM_APPCOMMAND message.
34 IDR_MAINFRAME ACCELERATORS 34 IDR_MAINFRAME ACCELERATORS
35 BEGIN 35 BEGIN
36 #if defined(ENABLE_BASIC_PRINTING) 36 // This really should be using the buildflag but the resource compiler fails on
37 // macro functions longer than 31 chars which this command produces. The BUILD
38 // sets this regular define for this target only for this line to consume.
39 #ifdef ENABLE_BASIC_PRINTING_FOR_RC // #if BUILDFLAG(ENABLE_BASIC_PRINTING)
37 "P", IDC_BASIC_PRINT, VIRTKEY, CONTROL, SHIFT 40 "P", IDC_BASIC_PRINT, VIRTKEY, CONTROL, SHIFT
38 #endif // ENABLE_BASIC_PRINTING 41 #endif // ENABLE_BASIC_PRINTING_FOR_RC
39 VK_LEFT, IDC_BACK, VIRTKEY, ALT 42 VK_LEFT, IDC_BACK, VIRTKEY, ALT
40 VK_BACK, IDC_BACK, VIRTKEY 43 VK_BACK, IDC_BACK, VIRTKEY
41 "D", IDC_BOOKMARK_PAGE, VIRTKEY, CONTROL 44 "D", IDC_BOOKMARK_PAGE, VIRTKEY, CONTROL
42 "D", IDC_BOOKMARK_ALL_TABS, VIRTKEY, CONTROL, SHIFT 45 "D", IDC_BOOKMARK_ALL_TABS, VIRTKEY, CONTROL, SHIFT
43 VK_DELETE, IDC_CLEAR_BROWSING_DATA, VIRTKEY, CONTROL, SHIFT 46 VK_DELETE, IDC_CLEAR_BROWSING_DATA, VIRTKEY, CONTROL, SHIFT
44 VK_F4, IDC_CLOSE_TAB, VIRTKEY, CONTROL 47 VK_F4, IDC_CLOSE_TAB, VIRTKEY, CONTROL
45 "W", IDC_CLOSE_TAB, VIRTKEY, CONTROL 48 "W", IDC_CLOSE_TAB, VIRTKEY, CONTROL
46 "W", IDC_CLOSE_WINDOW, VIRTKEY, CONTROL, SHIFT 49 "W", IDC_CLOSE_WINDOW, VIRTKEY, CONTROL, SHIFT
47 "F", IDC_FIND, VIRTKEY, CONTROL 50 "F", IDC_FIND, VIRTKEY, CONTROL
48 "G", IDC_FIND_NEXT, VIRTKEY, CONTROL 51 "G", IDC_FIND_NEXT, VIRTKEY, CONTROL
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 // 241 //
239 // Generated from the TEXTINCLUDE 3 resource. 242 // Generated from the TEXTINCLUDE 3 resource.
240 // 243 //
241 244
242 245
243 ///////////////////////////////////////////////////////////////////////////// 246 /////////////////////////////////////////////////////////////////////////////
244 #endif // not APSTUDIO_INVOKED 247 #endif // not APSTUDIO_INVOKED
245 248
246 // (temp change to touch this file or incremental builds may break now 249 // (temp change to touch this file or incremental builds may break now
247 // that we removed chrome_dll_version.rc from it) 250 // that we removed chrome_dll_version.rc from it)
OLDNEW
« no previous file with comments | « chrome/app/BUILD.gn ('k') | chrome/app/chrome_main_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698