Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/app/BUILD.gn

Issue 2458833005: Move printing defines to buildflag system. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/chrome_dll.rc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/BUILD.gn
diff --git a/chrome/app/BUILD.gn b/chrome/app/BUILD.gn
index 509deeaec9db2db0304fbb29857b347b99555dae..1e77e5120ad6f169c780ee319626c2ba9f0c6fb0 100644
--- a/chrome/app/BUILD.gn
+++ b/chrome/app/BUILD.gn
@@ -4,6 +4,7 @@
import("//build/config/ui.gni")
import("//chrome/common/features.gni")
+import("//printing/features/features.gni")
import("//services/service_manager/public/service_manifest.gni")
import("//tools/grit/grit_rule.gni")
@@ -24,6 +25,15 @@ source_set("chrome_dll_resources") {
]
if (is_win) {
sources += [ "chrome_dll.rc" ]
+ if (enable_basic_printing) {
+ # The resource compiler can only handle macro functions up to 31 chars
+ # which the buildflag system produces for this. Make a define so we can
+ # toggle off of the enable-basic-printing flag in the .rc file.
+ defines = [ "ENABLE_BASIC_PRINTING_FOR_RC" ]
+ }
+ deps = [
+ "//printing/features",
+ ]
}
}
@@ -307,6 +317,7 @@ static_library("test_support") {
"//components/startup_metric_utils/browser:lib",
"//content/public/app:both",
"//content/public/common",
+ "//printing/features",
"//ui/base",
]
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/app/chrome_dll.rc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698