Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2458093003: Add DCHECKs to validate ProfileIOData's list of protocols.

Created:
4 years, 1 month ago by ncarter (slow)
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, jam, cbentzel+watch_chromium.org, James Su, darin-cc_chromium.org, wjmaclean
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECKs to validate ProfileIOData's list of protocols. Every ProtocolHandler we create needs to be registered in ProfileIOData's static list of built-in protocols. Rename logic in a few places, using the term 'built-in' instead of 'handled', to distinguish between custom protocol handlers, and real protocol handlers that might return a network response. BUG=659492

Patch Set 1 #

Patch Set 2 : Merge remote-tracking branch 'origin/master' into detect_unregistered_schemes #

Patch Set 3 : Merge remote-tracking branch 'origin/master' into detect_unregistered_schemes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -54 lines) Patch
M chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context_getter.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 5 chunks +31 lines, -25 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (12 generated)
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-28 22:16:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458093003/1
4 years, 1 month ago (2016-10-28 22:16:44 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-28 22:19:44 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/252776) mac_chromium_compile_dbg_ng on ...
4 years, 1 month ago (2016-10-28 22:19:45 UTC) #4
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-28 22:31:08 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458093003/20001
4 years, 1 month ago (2016-10-28 22:32:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-28 22:50:24 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/58157)
4 years, 1 month ago (2016-10-28 22:50:25 UTC) #8
ncarter (slow)
The CQ bit was checked by nick@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 19:50:52 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458093003/40001
4 years, 1 month ago (2016-11-02 19:51:22 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 20:07:58 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 20:07:59 UTC) #12
Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Powered by Google App Engine
This is Rietveld 408576698