Add DCHECKs to validate ProfileIOData's list of protocols.

content/browser/storage_partition_impl_map.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/storage_partition_impl_map.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 151 matching lines @@
 #endif
 
 base::FilePath GetStoragePartitionDomainPath(
     const std::string& partition_domain) {
   CHECK(base::IsStringUTF8(partition_domain));
 
   return base::FilePath(kStoragePartitionDirname).Append(kExtensionsDirname)
       .Append(base::FilePath::FromUTF8Unsafe(partition_domain));
 }
 
+#if DCHECK_IS_ON()
+bool IsBuiltInProtocol(const std::string& scheme) {
+  GURL scheme_as_gurl(scheme + url::kStandardSchemeSeparator);
+  DCHECK(scheme_as_gurl.is_valid()) << scheme;
+  return GetContentClient()->browser()->IsHandledURL(scheme_as_gurl);
+}
+#endif
+
 // Helper function for doing a depth-first deletion of the data on disk.
 // Examines paths directly in |current_dir| (no recursion) and tries to
 // delete from disk anything that is in, or isn't a parent of something in
 // |paths_to_keep|. Paths that need further expansion are added to
 // |paths_to_consider|.
 void ObliterateOneDirectory(const base::FilePath& current_dir,
                             const std::vector<base::FilePath>& paths_to_keep,
                             std::vector<base::FilePath>* paths_to_consider) {
   CHECK(current_dir.IsAbsolute());
 
@@ skipping 247 matching lines @@
            additional_webui_schemes.begin();
        it != additional_webui_schemes.end();
        ++it) {
     protocol_handlers[*it] =
         linked_ptr<net::URLRequestJobFactory::ProtocolHandler>(
             URLDataManagerBackend::CreateProtocolHandler(
                 browser_context_->GetResourceContext(),
                 browser_context_->IsOffTheRecord(),
                 blob_storage_context).release());
   }
+
   protocol_handlers[kChromeDevToolsScheme] =
       linked_ptr<net::URLRequestJobFactory::ProtocolHandler>(
           CreateDevToolsProtocolHandler(browser_context_->GetResourceContext(),
                                         browser_context_->IsOffTheRecord()));
 
+#if DCHECK_IS_ON()
+  // The ContentBrowserClient's implementation of IsHandledURL must know about
+  // all protocols handled by the content layer.
+  for (const auto& handler : protocol_handlers)
+    DCHECK(IsBuiltInProtocol(handler.first)) << handler.first;
+#endif  // DCHECK_IS_ON()
+
   URLRequestInterceptorScopedVector request_interceptors;
   request_interceptors.push_back(
       ServiceWorkerRequestHandler::CreateInterceptor(
           browser_context_->GetResourceContext()).release());
   if (ForeignFetchRequestHandler::IsForeignFetchEnabled()) {
     request_interceptors.push_back(
         ForeignFetchRequestHandler::CreateInterceptor(
             browser_context_->GetResourceContext())
             .release());
   }
@@ skipping 151 matching lines @@
 
     // We do not call InitializeURLRequestContext() for media contexts because,
     // other than the HTTP cache, the media contexts share the same backing
     // objects as their associated "normal" request context.  Thus, the previous
     // call serves to initialize the media request context for this storage
     // partition as well.
   }
 }
 
 }  // namespace content