chrome/browser/custom_handlers/protocol_handler_registry.h - Issue 2458093003: Add DCHECKs to validate ProfileIOData's list of protocols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry.h

Issue 2458093003: Add DCHECKs to validate ProfileIOData's list of protocols.

Patch Set: Merge remote-tracking branch 'origin/master' into detect_unregistered_schemes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/custom_handlers/protocol_handler_registry.h

diff --git a/chrome/browser/custom_handlers/protocol_handler_registry.h b/chrome/browser/custom_handlers/protocol_handler_registry.h

index 00d08c269803e05becfdda4e27a9b100498cbd6e..1a43349cd1a3295c51af8ebaed793f49cf080bc9 100644

--- a/chrome/browser/custom_handlers/protocol_handler_registry.h

+++ b/chrome/browser/custom_handlers/protocol_handler_registry.h

@@ -48,7 +48,7 @@ class ProtocolHandlerRegistry : public KeyedService {

virtual ~Delegate();

virtual void RegisterExternalHandler(const std::string& protocol);

virtual void DeregisterExternalHandler(const std::string& protocol);

- virtual bool IsExternalHandlerRegistered(const std::string& protocol);

+ virtual bool CanSchemeBeOverridden(const std::string& protocol);

virtual scoped_refptr<shell_integration::DefaultProtocolClientWorker>

CreateShellWorker(

const shell_integration::DefaultWebClientWorkerCallback& callback,