Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 2458093003: Add DCHECKs to validate ProfileIOData's list of protocols.
Patch Set: Merge remote-tracking branch 'origin/master' into detect_unregistered_schemes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index a5297bf5eb9616d677baca558fe780c96f241bde..ab440e2f8346c40abbe7fc191998a89b192ce9e9 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -2055,7 +2055,7 @@ bool RenderViewContextMenu::IsSaveLinkAsEnabled() const {
return false;
return params_.link_url.is_valid() &&
- ProfileIOData::IsHandledProtocol(params_.link_url.scheme());
+ ProfileIOData::IsBuiltInProtocol(params_.link_url.scheme());
}
bool RenderViewContextMenu::IsSaveImageAsEnabled() const {
@@ -2076,9 +2076,9 @@ bool RenderViewContextMenu::IsSaveAsEnabled() const {
return false;
const GURL& url = params_.src_url;
- bool can_save =
- (params_.media_flags & WebContextMenuData::MediaCanSave) &&
- url.is_valid() && ProfileIOData::IsHandledProtocol(url.scheme());
+ bool can_save = (params_.media_flags & WebContextMenuData::MediaCanSave) &&
+ url.is_valid() &&
+ ProfileIOData::IsBuiltInProtocol(url.scheme());
#if defined(ENABLE_PRINT_PREVIEW)
// Do not save the preview PDF on the print preview page.
can_save = can_save &&
« no previous file with comments | « chrome/browser/profiles/profile_io_data.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698