Add DCHECKs to validate ProfileIOData's list of protocols.

chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <set>
@@ skipping 174 matching lines @@
   CreateShellWorker(
       const shell_integration::DefaultWebClientWorkerCallback& callback,
       const std::string& protocol) override {
     return new FakeProtocolClientWorker(callback, protocol, force_os_failure_);
   }
 
   void RegisterWithOSAsDefaultClient(
       const std::string& protocol,
       ProtocolHandlerRegistry* registry) override;
 
-  bool IsExternalHandlerRegistered(const std::string& protocol) override {
-    return registered_protocols_.find(protocol) != registered_protocols_.end();
-  }
-
   bool IsFakeRegisteredWithOS(const std::string& protocol) {
     return os_registered_protocols_.find(protocol) !=
         os_registered_protocols_.end();
   }
 
   void FakeRegisterWithOS(const std::string& protocol) {
     os_registered_protocols_.insert(protocol);
   }
 
   void Reset() {
     registered_protocols_.clear();
     os_registered_protocols_.clear();
     force_os_failure_ = false;
   }
 
   void set_force_os_failure(bool force) { force_os_failure_ = force; }
 
   bool force_os_failure() { return force_os_failure_; }
 
+  bool IsExternalHandlerRegistered(const std::string& protocol) {
+    return registered_protocols_.find(protocol) != registered_protocols_.end();
+  }
+
  private:
   std::set<std::string> registered_protocols_;
   std::set<std::string> os_registered_protocols_;
   bool force_os_failure_;
 };
 
 void OnShellWorkerFinished(ProtocolHandlerRegistry* registry,
                            FakeDelegate* delegate,
                            const std::string& protocol,
                            shell_integration::DefaultWebClientState state) {
@@ skipping 208 matching lines @@
 
 TEST_F(ProtocolHandlerRegistryTest, ClearDefaultMakesProtocolNotHandled) {
   registry()->OnAcceptRegisterProtocolHandler(test_protocol_handler());
   registry()->ClearDefault("test");
   ASSERT_FALSE(registry()->IsHandledProtocol("test"));
   ASSERT_TRUE(registry()->GetHandlerFor("test").IsEmpty());
 }
 
 TEST_F(ProtocolHandlerRegistryTest, DisableDeregistersProtocolHandlers) {
   ASSERT_FALSE(delegate()->IsExternalHandlerRegistered("test"));
+  ASSERT_TRUE(delegate()->CanSchemeBeOverridden("test"));
   registry()->OnAcceptRegisterProtocolHandler(test_protocol_handler());
   ASSERT_TRUE(delegate()->IsExternalHandlerRegistered("test"));
+  ASSERT_FALSE(delegate()->CanSchemeBeOverridden("test"));
 
   registry()->Disable();
   ASSERT_FALSE(delegate()->IsExternalHandlerRegistered("test"));
+  ASSERT_TRUE(delegate()->CanSchemeBeOverridden("test"));
   registry()->Enable();
   ASSERT_TRUE(delegate()->IsExternalHandlerRegistered("test"));
+  ASSERT_FALSE(delegate()->CanSchemeBeOverridden("test"));
 }
 
 TEST_F(ProtocolHandlerRegistryTest, IgnoreProtocolHandler) {
   registry()->OnIgnoreRegisterProtocolHandler(test_protocol_handler());
   ASSERT_TRUE(registry()->IsIgnored(test_protocol_handler()));
 
   registry()->RemoveIgnoredHandler(test_protocol_handler());
   ASSERT_FALSE(registry()->IsIgnored(test_protocol_handler()));
 }
 
@@ skipping 621 matching lines @@
   // added to pref.
   ASSERT_EQ(InPrefIgnoredHandlerCount(), 2);
   ASSERT_EQ(InMemoryIgnoredHandlerCount(), 4);
 
   registry()->RemoveIgnoredHandler(p2u1);
 
   // p2u1 installed by user and policy, so it is removed from pref alone.
   ASSERT_EQ(InPrefIgnoredHandlerCount(), 1);
   ASSERT_EQ(InMemoryIgnoredHandlerCount(), 4);
 }