chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc - Issue 2458093003: Add DCHECKs to validate ProfileIOData's list of protocols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

Issue 2458093003: Add DCHECKs to validate ProfileIOData's list of protocols.

Patch Set: Merge remote-tracking branch 'origin/master' into detect_unregistered_schemes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

diff --git a/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc b/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

index bf15ceb6ff573ac5259b38747962acdafa1337b7..a56bb234c85559f4ae313aa57632effa2cca9d54 100644

--- a/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

+++ b/chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc

@@ -23,7 +23,7 @@ metrics::OmniboxInputType::Type

ChromeAutocompleteSchemeClassifier::GetInputTypeForScheme(

const std::string& scheme) const {

if (base::IsStringASCII(scheme) &&

- (ProfileIOData::IsHandledProtocol(scheme) ||

+ (ProfileIOData::IsBuiltInProtocol(scheme) ||

base::LowerCaseEqualsASCII(scheme, content::kViewSourceScheme) ||

base::LowerCaseEqualsASCII(scheme, url::kJavaScriptScheme) ||

base::LowerCaseEqualsASCII(scheme, url::kDataScheme))) {

« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »