Remove invariant for input in fragment shader

Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Linux because AMD's driver
obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.

BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fdc6ab7c454d400dfc3d68ace3e4bcd192e3e5d5
Cr-Commit-Position: refs/heads/master@{#428625}

[qiankun, 2016-10-27 08:52:28]

Description was changed from

==========
Remove invariant for input in fragment shader on Linux Mesa

This CL enables a ANGLE workaround for Linux Mesa which removes invariant
declaration for GLSL >= 4.20.

BUG=639760, 659326
==========

to

==========
Remove invariant for input in fragment shader on Linux Mesa

This CL enables a ANGLE workaround for Linux Mesa which removes invariant
declaration for GLSL >= 4.20.

BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2016-10-27 19:16:54]

Description was changed from

==========
Remove invariant for input in fragment shader on Linux Mesa

This CL enables a ANGLE workaround for Linux Mesa which removes invariant
declaration for GLSL >= 4.20.

BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Linux because AMD's driver
on Linux obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.


BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2016-10-27 19:18:01]

qiankun.miao@intel.com changed reviewers:
+ cwallez@chromium.org, kbr@chromium.org, ynovikov@chromium.org,
zmo@chromium.org

[qiankun, 2016-10-27 19:18:44]

Enable https://chromium-review.googlesource.com/#/c/404228/4 in chromium. PTAL.

[qiankun, 2016-10-27 19:22:00]

Description was changed from

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Linux because AMD's driver
on Linux obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.


BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Mac OSX because AMD's driver
obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.


BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2016-10-27 19:26:56]

Patchset #4 (id:60001) has been deleted

[ynovikov, 2016-10-27 19:31:42]

On 2016/10/27 19:18:44, qiankun wrote:
> Enable https://chromium-review.googlesource.com/#/c/404228/4 in chromium.
PTAL.

lgtm, but fix Mac OSX -> Linux in the Description.

[qiankun, 2016-10-27 19:32:33]

Description was changed from

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Mac OSX because AMD's driver
obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.


BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Linux because AMD's driver
obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.


BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2016-10-27 19:33:23]

On 2016/10/27 19:31:42, ynovikov wrote:
> On 2016/10/27 19:18:44, qiankun wrote:
> > Enable https://chromium-review.googlesource.com/#/c/404228/4 in chromium.
> PTAL.
> 
> lgtm, but fix Mac OSX -> Linux in the Description.

Fixed.

[Ken Russell (switch to Gerrit), 2016-10-27 23:25:47]

lgtm

https://codereview.chromium.org/2456823002/diff/40001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2456823002/diff/40001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:2176: "description": "AMD drivers in
Linux require invariant must match between vertex and fragment shader",
"invariant must match" -> "invariant qualifier to match"

[qiankun, 2016-10-30 13:02:39]

The CQ bit was checked by qiankun.miao@intel.com

[qiankun, 2016-10-30 13:02:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
ynovikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2456823002/#ps80001
(title: "fix workaround description")

[commit-bot: I haz the power, 2016-10-30 13:02:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 13:51:34]

Description was changed from

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Linux because AMD's driver
obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.


BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Linux because AMD's driver
obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.


BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-30 13:51:35]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-30 13:54:10]

Description was changed from

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Linux because AMD's driver
obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.


BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove invariant for input in fragment shader

This CL enables a ANGLE workaround which removes invariant declaration
for GLSL >= 4.20 on all platforms except AMD Linux because AMD's driver
obviously contradicts the spec by forcing invariance to match
between vertex and fragment shaders.

BUG=639760, 659326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fdc6ab7c454d400dfc3d68ace3e4bcd192e3e5d5
Cr-Commit-Position: refs/heads/master@{#428625}
==========

[commit-bot: I haz the power, 2016-10-30 13:54:11]

Patchset 4 (id:??) landed as
https://crrev.com/fdc6ab7c454d400dfc3d68ace3e4bcd192e3e5d5
Cr-Commit-Position: refs/heads/master@{#428625}