Rename attach and detach to createRenderTree/destroyRenderTree

Rename attach and detach to createRenderTree/destroyRenderTree

This patch renames attach and detach to something more sensible. It also renames
lazyAttach to scheduleRenderTreeCreation.

It leaves the attached() bit since I'm not sure of a good name for that yet.

[esprehn, 2013-09-24 21:17:41]

Do you think attachRenderTree would be better?

[leviw_travelin_and_unemployed, 2013-09-24 21:23:00]

On 2013/09/24 21:17:41, esprehn wrote:
> Do you think attachRenderTree would be better?

I prefer attachRenderTree, but it may just be because it bridges the gap between
the old and new names. Either way, I like and support this change.

[ojan, 2013-09-24 22:41:24]

lgtm

Please make the naming consistent (s/reconstruct/recreate).

https://codereview.chromium.org/24430002/diff/1/Source/core/dom/Node.h
File Source/core/dom/Node.h (right):

https://codereview.chromium.org/24430002/diff/1/Source/core/dom/Node.h#newcod...
Source/core/dom/Node.h:411: void scheduleRenderTreeReconstruction();
How about scheduleRenderTreeRecreation?

https://codereview.chromium.org/24430002/diff/1/Source/core/dom/Node.h#newcod...
Source/core/dom/Node.h:541: bool reconstructingRenderTree;
Ditto...recreatingRenderTree.

https://codereview.chromium.org/24430002/diff/1/Source/core/html/HTMLObjectEl...
File Source/core/html/HTMLObjectElement.cpp (right):

https://codereview.chromium.org/24430002/diff/1/Source/core/html/HTMLObjectEl...
Source/core/html/HTMLObjectElement.cpp:359: void
HTMLObjectElement::reattachFallbackContent()
Rename this too? Or add a FIXME to rename it.

[esprehn, 2013-09-24 22:45:27]

On 2013/09/24 22:41:24, ojan wrote:
> lgtm
> 
> Please make the naming consistent (s/reconstruct/recreate).

Woops, I had it one name and then renamed it before upload. I'll fix it all
before landing (should be recreate).

[eseidel, 2014-02-14 03:33:43]

Did you give up? :)

[esprehn, 2014-02-15 01:22:57]

On 2014/02/14 03:33:43, eseidel wrote:
> Did you give up? :)

Yeah so many merge conflicts and a busted CQ. I should try again and dcommit
this time.

[esprehn, 2016-02-10 00:12:40]

We should rename these things someday...