Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: Source/core/dom/Text.cpp

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Text.cpp
diff --git a/Source/core/dom/Text.cpp b/Source/core/dom/Text.cpp
index 5c300c547bb190a0acef10445152c9d287853e43..008c0325d442851a0e72035af5dec1537d31c7f8 100644
--- a/Source/core/dom/Text.cpp
+++ b/Source/core/dom/Text.cpp
@@ -299,10 +299,10 @@ RenderText* Text::createTextRenderer(RenderStyle* style)
return new RenderText(this, dataImpl());
}
-void Text::attach(const AttachContext& context)
+void Text::createRenderTree(const AttachContext& context)
{
NodeRenderingContext(this, context.resolvedStyle).createRendererForTextIfNeeded();
- CharacterData::attach(context);
+ CharacterData::createRenderTree(context);
}
bool Text::recalcTextStyle(StyleRecalcChange change)
@@ -314,7 +314,7 @@ bool Text::recalcTextStyle(StyleRecalcChange change)
renderer->setText(dataImpl());
clearNeedsStyleRecalc();
} else if (needsStyleRecalc() || needsWhitespaceRenderer()) {
- reattach();
+ recreateRenderTree();
return true;
}
return false;
@@ -336,7 +336,7 @@ void Text::updateTextRenderer(unsigned offsetOfReplacedData, unsigned lengthOfRe
return;
RenderText* textRenderer = toRenderText(renderer());
if (!textRenderer || !textRendererIsNeeded(NodeRenderingContext(this, textRenderer->style()))) {
- lazyReattach();
+ scheduleRenderTreeReconstruction();
// FIXME: Editing should be updated so this is not neccesary.
if (recalcStyleBehavior == DeprecatedRecalcStyleImmediatlelyForEditing)
document().updateStyleIfNeeded();

Powered by Google App Engine
This is Rietveld 408576698