Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: Source/core/html/HTMLInputElement.h

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLInputElement.h
diff --git a/Source/core/html/HTMLInputElement.h b/Source/core/html/HTMLInputElement.h
index 6729613694c3a0fab0c3fef858601ec0a8c6367f..dda4e9e58354396c8a4af7bf2c892092cecb4a38 100644
--- a/Source/core/html/HTMLInputElement.h
+++ b/Source/core/html/HTMLInputElement.h
@@ -180,7 +180,7 @@ public:
virtual bool rendererIsNeeded(const RenderStyle&);
virtual RenderObject* createRenderer(RenderStyle*);
- virtual void detach(const AttachContext& = AttachContext()) OVERRIDE;
+ virtual void destroyRenderTree(const AttachContext& = AttachContext()) OVERRIDE;
// FIXME: For isActivatedSubmit and setActivatedSubmit, we should use the NVI-idiom here by making
// it private virtual in all classes and expose a public method in HTMLFormControlElement to call
@@ -330,7 +330,7 @@ private:
virtual void copyNonAttributePropertiesFromElement(const Element&);
- virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
+ virtual void createRenderTree(const AttachContext& = AttachContext()) OVERRIDE;
virtual bool appendFormData(FormDataList&, bool);

Powered by Google App Engine
This is Rietveld 408576698