Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 24430002: Rename attach and detach to createRenderTree/destroyRenderTree (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 } 298 }
299 size = max(size, 1); 299 size = max(size, 1);
300 300
301 // Ensure that we've determined selectedness of the items at least once prior to changing the size. 301 // Ensure that we've determined selectedness of the items at least once prior to changing the size.
302 if (oldSize != size) 302 if (oldSize != size)
303 updateListItemSelectedStates(); 303 updateListItemSelectedStates();
304 304
305 m_size = size; 305 m_size = size;
306 setNeedsValidityCheck(); 306 setNeedsValidityCheck();
307 if (m_size != oldSize && attached()) { 307 if (m_size != oldSize && attached()) {
308 lazyReattach(); 308 scheduleRenderTreeReconstruction();
309 setRecalcListItems(); 309 setRecalcListItems();
310 } 310 }
311 } else if (name == multipleAttr) 311 } else if (name == multipleAttr)
312 parseMultipleAttribute(value); 312 parseMultipleAttribute(value);
313 else if (name == accesskeyAttr) { 313 else if (name == accesskeyAttr) {
314 // FIXME: ignore for the moment. 314 // FIXME: ignore for the moment.
315 // 315 //
316 } else 316 } else
317 HTMLFormControlElementWithState::parseAttribute(name, value); 317 HTMLFormControlElementWithState::parseAttribute(name, value);
318 } 318 }
(...skipping 675 matching lines...) Expand 10 before | Expand all | Expand 10 after
994 setOptionsChangedOnRenderer(); 994 setOptionsChangedOnRenderer();
995 setNeedsValidityCheck(); 995 setNeedsValidityCheck();
996 } 996 }
997 997
998 void HTMLSelectElement::parseMultipleAttribute(const AtomicString& value) 998 void HTMLSelectElement::parseMultipleAttribute(const AtomicString& value)
999 { 999 {
1000 bool oldUsesMenuList = usesMenuList(); 1000 bool oldUsesMenuList = usesMenuList();
1001 m_multiple = !value.isNull(); 1001 m_multiple = !value.isNull();
1002 setNeedsValidityCheck(); 1002 setNeedsValidityCheck();
1003 if (oldUsesMenuList != usesMenuList()) 1003 if (oldUsesMenuList != usesMenuList())
1004 lazyReattachIfAttached(); 1004 scheduleRenderTreeRecreationIfAttached();
1005 } 1005 }
1006 1006
1007 bool HTMLSelectElement::appendFormData(FormDataList& list, bool) 1007 bool HTMLSelectElement::appendFormData(FormDataList& list, bool)
1008 { 1008 {
1009 const AtomicString& name = this->name(); 1009 const AtomicString& name = this->name();
1010 if (name.isEmpty()) 1010 if (name.isEmpty())
1011 return false; 1011 return false;
1012 1012
1013 bool successful = false; 1013 bool successful = false;
1014 const Vector<HTMLElement*>& items = listItems(); 1014 const Vector<HTMLElement*>& items = listItems();
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
1572 return true; 1572 return true;
1573 } 1573 }
1574 1574
1575 bool HTMLSelectElement::anonymousIndexedSetterRemove(unsigned index, ExceptionSt ate& es) 1575 bool HTMLSelectElement::anonymousIndexedSetterRemove(unsigned index, ExceptionSt ate& es)
1576 { 1576 {
1577 remove(index); 1577 remove(index);
1578 return true; 1578 return true;
1579 } 1579 }
1580 1580
1581 } // namespace 1581 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698