[DevTools] Refactor connection-related classes.

[DevTools] Refactor connection-related classes.

Extracted small connection interface, it's params and factory.
Supported connect/disconnect for all main connection types.
Renamed previous Connection to TargetPrototype, which will be merged to Target soon.

BUG=648775
Committed: https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e
Cr-Commit-Position: refs/heads/master@{#427521}

[dgozman, 2016-10-21 05:44:44]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 05:45:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 07:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 07:33:57]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-21 16:51:11]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-10-21 16:51:12]

Could you please take a look?

[pfeldman, 2016-10-21 21:04:34]

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
(right):

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:22:
this._channel.addEventListener(InspectorBackendClass.Channel.Events.MessageReceived,
this._dispatchProtocolMessage, this);
design: You don't want to expose the MessageReceived as an event API, it needs
to be private to the handler as it was previously.

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js:44:
WebInspector.targetManager.mainChannelInterceptor().yieldMainChannel();
design: only the one how has connection should be able to yield it.

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
(right):

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js:37:
* @param {{message: !Object|string}} params
design: we should not use either or typing.

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:275:
WebInspector.targetManager.setMainChannelInterceptor(this);
design: awkward API

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:290:
this._mainChannel.reconnect(() => fulfill(this._mainChannel));
return this._mainChannel.reconnect().then(() => this._mainChannel);

https://codereview.chromium.org/2441933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:309: return
WebInspector.WebSocketChannel.Create(ws).then(channel => {
You are just renaming connection to channel, while still leaving the connection
entity. I'd rather leave things as is and moved non-channel connection bits into
targets. That way all this code stays.

[dgozman, 2016-10-25 00:18:21]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 00:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-10-25 00:21:21]

Description was changed from

==========
[DevTools] Split Connection and Channel.

BUG=648775
==========

to

==========
[DevTools] Refactor connection-related classes.

Extracted small connection interface, it's params and factory.
Supported connect/disconnect for all main connection types.
Renamed previous Connection to TargetPrototype, which will be merged to Target
soon.

BUG=648775
==========

[dgozman, 2016-10-25 00:21:46]

PTAL

[commit-bot: I haz the power, 2016-10-25 00:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:23:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-10-25 19:22:46]

lgtm

[dgozman, 2016-10-25 19:43:46]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-10-25 19:43:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2441933002/#ps60001
(title: "rebase over semicolons")

[commit-bot: I haz the power, 2016-10-25 19:44:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 20:43:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 20:43:30]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-10-25 21:25:42]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-10-25 21:25:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2441933002/#ps80001
(title: "tests.js")

[commit-bot: I haz the power, 2016-10-25 21:26:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:01:18]

Description was changed from

==========
[DevTools] Refactor connection-related classes.

Extracted small connection interface, it's params and factory.
Supported connect/disconnect for all main connection types.
Renamed previous Connection to TargetPrototype, which will be merged to Target
soon.

BUG=648775
==========

to

==========
[DevTools] Refactor connection-related classes.

Extracted small connection interface, it's params and factory.
Supported connect/disconnect for all main connection types.
Renamed previous Connection to TargetPrototype, which will be merged to Target
soon.

BUG=648775
==========

[commit-bot: I haz the power, 2016-10-25 23:01:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-25 23:03:19]

Description was changed from

==========
[DevTools] Refactor connection-related classes.

Extracted small connection interface, it's params and factory.
Supported connect/disconnect for all main connection types.
Renamed previous Connection to TargetPrototype, which will be merged to Target
soon.

BUG=648775
==========

to

==========
[DevTools] Refactor connection-related classes.

Extracted small connection interface, it's params and factory.
Supported connect/disconnect for all main connection types.
Renamed previous Connection to TargetPrototype, which will be merged to Target
soon.

BUG=648775

Committed: https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e
Cr-Commit-Position: refs/heads/master@{#427521}
==========

[commit-bot: I haz the power, 2016-10-25 23:03:21]

Patchset 5 (id:??) landed as
https://crrev.com/6274a2d207fc8383d1182204b2a900d80c3d3f0e
Cr-Commit-Position: refs/heads/master@{#427521}