third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 2441933002: [DevTools] Refactor connection-related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)

Patch Set: tests.js Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index c6115312af4f4ca4c7688e77ce61d5c66ac7128b..a6d3458d6984267f0841df0385735bcdd1734640 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -498,7 +498,7 @@ WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent = function(event, tar

function linkifyLocationAsText(scriptId, lineNumber, columnNumber)

{

var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);

- if (!target || target.isDetached() || !scriptId || !debuggerModel)

+ if (!target || target.isDisposed() || !scriptId || !debuggerModel)

return null;

var rawLocation = debuggerModel.createRawLocationByScriptId(scriptId, lineNumber, columnNumber);

if (!rawLocation)

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/WorkerManager.js ('k') | no next file » | no next file with comments »