third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js - Issue 2441933002: [DevTools] Refactor connection-related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)

Patch Set: tests.js Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/Tests.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js b/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

index b8ec6555b768a359e735433614f68494bc4a0418..178d9211bd89068bb83f75d3128faee7730d80cd 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

@@ -34,7 +34,7 @@ WebInspector.Audits2Panel.prototype = {

_stop: function()

{

this._send("stop").then(() => {

- this._rawConnection.yieldConnection();

+ this._rawConnection.disconnect();

this._backend.dispose();

delete this._backend;

delete this._backendPromise;

@@ -51,7 +51,7 @@ WebInspector.Audits2Panel.prototype = {

if (!this._backendPromise) {

this._backendPromise = WebInspector.serviceManager.createAppService("audits2_worker", "Audits2Service", false).then(backend => {

this._backend = backend;

- this._backend.on("sendProtocolMessage", result => this._rawConnection.send(result.message));

+ this._backend.on("sendProtocolMessage", result => this._rawConnection.sendMessage(result.message));

});

}

return this._backendPromise.then(() => this._backend ? this._backend.send(method, params) : undefined);