third_party/WebKit/Source/devtools/front_end/components/Linkifier.js - Issue 2441933002: [DevTools] Refactor connection-related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)

Patch Set: tests.js Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

index 393a2e7f3c8a819a42d2cc3a069d2a2ebcb47a5a..e9376770ae072623ca3d76b6f4330e5bf6bd951d 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

@@ -165,7 +165,7 @@ WebInspector.Linkifier.prototype = {

maybeLinkifyScriptLocation: function(target, scriptId, sourceURL, lineNumber, columnNumber, classes)

{

var fallbackAnchor = sourceURL ? WebInspector.linkifyResourceAsNode(sourceURL, lineNumber, columnNumber, classes) : null;

- if (!target || target.isDetached())

+ if (!target || target.isDisposed())

return fallbackAnchor;

var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);

if (!debuggerModel)

@@ -235,7 +235,7 @@ WebInspector.Linkifier.prototype = {

var topFrame = stackTrace.callFrames[0];

var fallbackAnchor = WebInspector.linkifyResourceAsNode(topFrame.url, topFrame.lineNumber, topFrame.columnNumber, classes);

- if (target.isDetached())

+ if (target.isDisposed())

return fallbackAnchor;

var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);