Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)
Patch Set: tests.js Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
index a4c4ed41b237cd6763b953cfa791aac2769a2a84..d370cfb8a2d0c94f68228f092690bb841c09ff3e 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
@@ -671,7 +671,6 @@ WebInspector.NetworkDispatcher.prototype = {
WebInspector.MultitargetNetworkManager = function()
{
WebInspector.Object.call(this);
- WebInspector.targetManager.observeTargets(this);
/** @type {!Set<string>} */
this._blockedURLs = new Set();
@@ -685,6 +684,8 @@ WebInspector.MultitargetNetworkManager = function()
this._agents = new Set();
/** @type {!WebInspector.NetworkManager.Conditions} */
this._networkConditions = WebInspector.NetworkManager.NoThrottlingConditions;
+
+ WebInspector.targetManager.observeTargets(this, WebInspector.Target.Capability.Network);
};
/** @enum {symbol} */
@@ -789,8 +790,8 @@ WebInspector.MultitargetNetworkManager.prototype = {
setExtraHTTPHeaders: function(headers)
{
this._extraHeaders = headers;
- for (var target of WebInspector.targetManager.targets())
- target.networkAgent().setExtraHTTPHeaders(this._extraHeaders);
+ for (var agent of this._agents)
+ agent.setExtraHTTPHeaders(this._extraHeaders);
},
/**
@@ -805,8 +806,8 @@ WebInspector.MultitargetNetworkManager.prototype = {
{
var userAgent = this._currentUserAgent();
WebInspector.ResourceLoader.targetUserAgent = userAgent;
- for (var target of WebInspector.targetManager.targets())
- target.networkAgent().setUserAgentOverride(userAgent);
+ for (var agent of this._agents)
+ agent.setUserAgentOverride(userAgent);
},
/**
@@ -858,8 +859,8 @@ WebInspector.MultitargetNetworkManager.prototype = {
_addBlockedURL: function(url)
{
this._blockedURLs.add(url);
- for (var target of WebInspector.targetManager.targets())
- target.networkAgent().addBlockedURL(url);
+ for (var agent of this._agents)
+ agent.addBlockedURL(url);
},
/**
@@ -868,20 +869,20 @@ WebInspector.MultitargetNetworkManager.prototype = {
_removeBlockedURL: function(url)
{
this._blockedURLs.delete(url);
- for (var target of WebInspector.targetManager.targets())
- target.networkAgent().removeBlockedURL(url);
+ for (var agent of this._agents)
+ agent.removeBlockedURL(url);
},
clearBrowserCache: function()
{
- for (var target of WebInspector.targetManager.targets())
- target.networkAgent().clearBrowserCache();
+ for (var agent of this._agents)
+ agent.clearBrowserCache();
},
clearBrowserCookies: function()
{
- for (var target of WebInspector.targetManager.targets())
- target.networkAgent().clearBrowserCookies();
+ for (var agent of this._agents)
+ agent.clearBrowserCookies();
},
/**

Powered by Google App Engine
This is Rietveld 408576698