Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2441933002: [DevTools] Refactor connection-related classes. (Closed)
Patch Set: tests.js Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
index ccb848966ae65fee1abf93ff3dd6c11eb30f0482..85e2e4aee06d1567bbf6b9d87ca9411d067d8812 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
@@ -183,13 +183,13 @@ WebInspector.TargetManager.prototype = {
/**
* @param {string} name
* @param {number} capabilitiesMask
- * @param {!InspectorBackendClass.Connection} connection
+ * @param {!InspectorBackendClass.Connection.Factory} connectionFactory
* @param {?WebInspector.Target} parentTarget
* @return {!WebInspector.Target}
*/
- createTarget: function(name, capabilitiesMask, connection, parentTarget)
+ createTarget: function(name, capabilitiesMask, connectionFactory, parentTarget)
{
- var target = new WebInspector.Target(this, name, capabilitiesMask, connection, parentTarget);
+ var target = new WebInspector.Target(this, name, capabilitiesMask, connectionFactory, parentTarget);
var logAgent = target.hasLogCapability() ? target.logAgent() : null;
@@ -236,35 +236,20 @@ WebInspector.TargetManager.prototype = {
},
/**
- * @param {function()} factory
+ * @param {function(function(string)):!Promise<!InspectorBackendClass.Connection>} interceptor
*/
- setMainTargetFactory: function(factory)
+ setMainConnectionInterceptor: function(interceptor)
{
- this._mainTargetFactory = factory;
+ this._mainConnectionInterceptor = interceptor;
},
/**
- * @param {function(string)} dispatch
- * @return {!Promise<!WebInspector.RawProtocolConnection>}
+ * @param {function(string)} onMessage
+ * @return {!Promise<!InspectorBackendClass.Connection>}
*/
- interceptMainConnection: function(dispatch)
+ interceptMainConnection: function(onMessage)
{
- var target = WebInspector.targetManager.mainTarget();
- if (target)
- target.connection().close();
-
- var fulfill;
- var result = new Promise(resolve => fulfill = resolve);
- InspectorFrontendHost.reattach(() => fulfill(new WebInspector.RawProtocolConnection(dispatch, yieldCallback.bind(this))));
- return result;
-
- /**
- * @this {WebInspector.TargetManager}
- */
- function yieldCallback()
- {
- InspectorFrontendHost.reattach(this._mainTargetFactory());
- }
+ return this._mainConnectionInterceptor.call(null, onMessage);
},
/**

Powered by Google App Engine
This is Rietveld 408576698