INPUT element: code cleanup around setValue().

INPUT element: code cleanup around setValue().

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().
  Make sure this is only for ValueMode::kValue.

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.

* InputType::setValue()
  Make sure this is only for ValueMode::kValue.

This CL has no behavior changes.

Committed: https://crrev.com/760682ed1d9e83e40ef158f06a83b7fe626de745
Cr-Commit-Position: refs/heads/master@{#427026}

[tkent, 2016-10-20 08:10:05]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 08:10:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 08:30:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 08:30:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tkent, 2016-10-20 13:52:41]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 13:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-20 14:30:31]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-10-20 15:28:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 15:28:45]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-10-21 00:06:58]

Description was changed from

==========
INPUT element: code cleanup around setValue().
==========

to

==========
INPUT element: code cleanup around setValue().

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.
==========

[tkent, 2016-10-21 00:08:03]

Description was changed from

==========
INPUT element: code cleanup around setValue().

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.
==========

to

==========
INPUT element: code cleanup around setValue().

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().
  Make sure this is only for ValueMode::kValue.

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.

* InputType::setValue()
  Make sure this is only for ValueMode::kValue.
==========

[tkent, 2016-10-21 00:08:30]

Description was changed from

==========
INPUT element: code cleanup around setValue().

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().
  Make sure this is only for ValueMode::kValue.

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.

* InputType::setValue()
  Make sure this is only for ValueMode::kValue.
==========

to

==========
INPUT element: code cleanup around setValue().

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().
  Make sure this is only for ValueMode::kValue.

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.

* InputType::setValue()
  Make sure this is only for ValueMode::kValue.

This CL has no behavior changes.
==========

[tkent, 2016-10-21 00:08:48]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-10-21 00:08:49]

Hattori-san, would you review this please?

[keishi, 2016-10-24 04:23:40]

LGTM

[tkent, 2016-10-24 04:39:58]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-10-24 04:40:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 06:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 06:32:33]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[tkent, 2016-10-24 06:41:04]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-10-24 06:41:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 07:54:13]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-24 07:55:51]

Description was changed from

==========
INPUT element: code cleanup around setValue().

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().
  Make sure this is only for ValueMode::kValue.

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.

* InputType::setValue()
  Make sure this is only for ValueMode::kValue.

This CL has no behavior changes.
==========

to

==========
INPUT element: code cleanup around setValue().

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().
  Make sure this is only for ValueMode::kValue.

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.

* InputType::setValue()
  Make sure this is only for ValueMode::kValue.

This CL has no behavior changes.

Committed: https://crrev.com/760682ed1d9e83e40ef158f06a83b7fe626de745
Cr-Commit-Position: refs/heads/master@{#427026}
==========

[commit-bot: I haz the power, 2016-10-24 07:55:51]

Patchset 1 (id:??) landed as
https://crrev.com/760682ed1d9e83e40ef158f06a83b7fe626de745
Cr-Commit-Position: refs/heads/master@{#427026}