Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2435973002: INPUT element: code cleanup around setValue(). (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 HTMLDataListElement* dataList() const; 224 HTMLDataListElement* dataList() const;
225 bool hasValidDataListOptions() const; 225 bool hasValidDataListOptions() const;
226 void listAttributeTargetChanged(); 226 void listAttributeTargetChanged();
227 // Associated <datalist> options which match to the current INPUT value. 227 // Associated <datalist> options which match to the current INPUT value.
228 HeapVector<Member<HTMLOptionElement>> filteredDataListOptions() const; 228 HeapVector<Member<HTMLOptionElement>> filteredDataListOptions() const;
229 229
230 HTMLInputElement* checkedRadioButtonForGroup(); 230 HTMLInputElement* checkedRadioButtonForGroup();
231 bool isInRequiredRadioButtonGroup(); 231 bool isInRequiredRadioButtonGroup();
232 232
233 // Functions for InputType classes. 233 // Functions for InputType classes.
234 void setValueInternal(const String&, TextFieldEventBehavior); 234 void setNonAttributeValue(const String&);
235 bool valueAttributeWasUpdatedAfterParsing() const { 235 bool valueAttributeWasUpdatedAfterParsing() const {
236 return m_valueAttributeWasUpdatedAfterParsing; 236 return m_valueAttributeWasUpdatedAfterParsing;
237 } 237 }
238 void updateView(); 238 void updateView();
239 bool needsToUpdateViewValue() const { return m_needsToUpdateViewValue; } 239 bool needsToUpdateViewValue() const { return m_needsToUpdateViewValue; }
240 void setInnerEditorValue(const String&) override; 240 void setInnerEditorValue(const String&) override;
241 241
242 // For test purposes. 242 // For test purposes.
243 void selectColorInColorChooser(const Color&); 243 void selectColorInColorChooser(const Color&);
244 void endColorChooser(); 244 void endColorChooser();
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
435 // assumes that it lives as long as its owning element lives. If we move the 435 // assumes that it lives as long as its owning element lives. If we move the
436 // loader into the ImageInput object we may delete the loader while this 436 // loader into the ImageInput object we may delete the loader while this
437 // element lives on. 437 // element lives on.
438 Member<HTMLImageLoader> m_imageLoader; 438 Member<HTMLImageLoader> m_imageLoader;
439 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver; 439 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver;
440 }; 440 };
441 441
442 } // namespace blink 442 } // namespace blink
443 443
444 #endif // HTMLInputElement_h 444 #endif // HTMLInputElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698